Add cloudstack_limits data source and resource

[ianc769]

Adding limits as a terraform managed resource option -> https://cloudstack.apache.org/api/apidocs-4.20/apis/updateResourceLimit.html

Contributes to #82

Using this code for example:

resource "random_uuid" "example" {
}

resource "cloudstack_domain" "example" {
  name             = "example-domain"
  network_domain   = "example.local"
  domain_id        = random_uuid.example.result
  parent_domain_id = "65c9befb-1a1c-11f0-85c0-460f7764ea25"
}

# Set limit in a domain
resource "cloudstack_limits" "cpu_limit" {
  type       = "cpu"
  max        = 42
  domainid   = random_uuid.example.result
  depends_on = [cloudstack_domain.example]

}

# Set volume limit for a specific account in a domain
resource "cloudstack_limits" "volume_limit" {
  type     = "volume"
  max      = 22
  account  = "limits.test"
  domainid = "861bf423-e531-48dc-9bdc-a3183ae0fb0f"
}

# Set primary storage limit for a project
resource "cloudstack_limits" "storage_limit" {
  type      = "primarystorage"
  max       = 1423                                   # GB
  projectid = "c3638a06-9598-4c34-8f89-891beda43eca" // Example project ID
}

Terraform used the selected providers to generate the following execution plan. Resource actions are indicated with the following symbols:
  + create

Terraform will perform the following actions:

  # cloudstack_domain.example will be created
  + resource "cloudstack_domain" "example" {
      + domain_id        = (known after apply)
      + id               = (known after apply)
      + name             = "example-domain"
      + network_domain   = "example.local"
      + parent_domain_id = "65c9befb-1a1c-11f0-85c0-460f7764ea25"
    }

  # cloudstack_limits.cpu_limit will be created
  + resource "cloudstack_limits" "cpu_limit" {
      + domainid = (known after apply)
      + id       = (known after apply)
      + max      = 42
      + type     = "cpu"
    }

  # cloudstack_limits.storage_limit will be created
  + resource "cloudstack_limits" "storage_limit" {
      + id        = (known after apply)
      + max       = 1423
      + projectid = "c3638a06-9598-4c34-8f89-891beda43eca"
      + type      = "primarystorage"
    }

  # cloudstack_limits.volume_limit will be created
  + resource "cloudstack_limits" "volume_limit" {
      + account  = "limits.test"
      + domainid = "861bf423-e531-48dc-9bdc-a3183ae0fb0f"
      + id       = (known after apply)
      + max      = 22
      + type     = "volume"
    }

  # random_uuid.example will be created
  + resource "random_uuid" "example" {
      + id     = (known after apply)
      + result = (known after apply)
    }

Plan: 5 to add, 0 to change, 0 to destroy.

random_uuid.example: Creating...
random_uuid.example: Creation complete after 0s [id=3e435b24-880a-6bae-50a6-fbd5c9be402b]
cloudstack_limits.volume_limit: Creating...
cloudstack_limits.storage_limit: Creating...
cloudstack_domain.example: Creating...
cloudstack_domain.example: Creation complete after 0s [id=3e435b24-880a-6bae-50a6-fbd5c9be402b]
cloudstack_limits.volume_limit: Creation complete after 0s [id=2-account-limits.test-861bf423-e531-48dc-9bdc-a3183ae0fb0f]
cloudstack_limits.cpu_limit: Creating...
cloudstack_limits.storage_limit: Creation complete after 0s [id=10-project-c3638a06-9598-4c34-8f89-891beda43eca]
cloudstack_limits.cpu_limit: Creation complete after 0s [id=8-domain-3e435b24-880a-6bae-50a6-fbd5c9be402b]

Apply complete! Resources: 5 added, 0 changed, 0 destroyed.

[Copilot]

Pull Request Overview

This PR adds CloudStack resource limits management by introducing a new cloudstack_limits resource and data source. These allow Terraform to manage CloudStack resource limits for different entities (accounts, domains, projects) using the CloudStack updateResourceLimit API.

Key changes:

• Implements CRUD operations for CloudStack resource limits with support for all limit types
• Adds data source to query existing resource limits with filtering capabilities
• Provides comprehensive test coverage for various limit types and entity scopes

Reviewed Changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated 5 comments.

Show a summary per file

File	Description
cloudstack/resource_cloudstack_limits.go	Core resource implementation with CRUD operations and resource type mapping
cloudstack/data_source_cloudstack_limits.go	Data source for querying resource limits with filtering options
cloudstack/resource_cloudstack_limits_test.go	Comprehensive test suite covering different limit types and scenarios
cloudstack/provider.go	Provider registration for the new resource and data source
website/docs/r/limits.html.markdown	Resource documentation with examples and argument reference
website/docs/d/limits.html.markdown	Data source documentation with usage examples

[Copilot]

The resourceTypeMap is missing some resource types that are documented in the data source (publicip, eip, autoscalevmgroup). This inconsistency could cause confusion and limit functionality.

Suggested change

	"instance": 0,
	"ip": 1,
	"volume": 2,
	"snapshot": 3,
	"template": 4,
	"project": 5,
	"network": 6,
	"vpc": 7,
	"cpu": 8,
	"memory": 9,
	"primarystorage": 10,
	"secondarystorage": 11,
	"instance": 0,
	"ip": 1,
	"volume": 2,
	"snapshot": 3,
	"template": 4,
	"project": 5,
	"network": 6,
	"vpc": 7,
	"cpu": 8,
	"memory": 9,
	"primarystorage": 10,
	"secondarystorage": 11,
	"publicip": 12,
	"eip": 13,
	"autoscalevmgroup": 14,

[Copilot]

The "type" field is duplicated in the ImportStateVerifyIgnore slice. This should only appear once.

Suggested change

	ImportStateVerifyIgnore: []string{"domainid", "type", "type", "max"},
	ImportStateVerifyIgnore: []string{"domainid", "type", "max"},

[Copilot]

This condition prevents setting a limit to 0, which might be a valid limit value. Consider using d.HasChange("max") or checking if the value was explicitly set instead.

Suggested change

	if max != 0 {
	p.SetMax(int64(max))
	if v, ok := d.GetOk("max"); ok {
	p.SetMax(int64(v.(int)))

[Copilot]

This condition prevents setting a limit to 0, which might be a valid limit value. Consider using d.HasChange("max") or checking if the value was explicitly set instead.

Suggested change

	if max != 0 {
	p.SetMax(int64(max))
	if maxVal, ok := d.GetOk("max"); ok {
	p.SetMax(int64(maxVal.(int)))

[Copilot]

Inconsistent indentation with excessive whitespace. Should align with the other fields using consistent spacing.

Suggested change

	type = "volume"
	type = "volume"