Support for LIKE expressions as PostFilter in SAI #4290
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pranavshenoy
force-pushed
the
like-postindex-filter
branch
from
ad0a9e0 to
76e1487
Compare
Since LIKE is filtered in post filter, ALLOW FILTERING is required. I tested it with some basic queries. Will do further manual testing + unit tests. It would be helpful for early reviews. patch by Pranav Shenoy; reviewed by Caleb Rackliffe for CASSANDRA-17198
pranavshenoy
force-pushed
the
like-postindex-filter
branch
from
76e1487 to
35beebd
Compare
maedhroz
reviewed
Aug 9, 2025
| if (!restriction.hasSupportingIndex(indexRegistry)) | ||
| throw invalidRequest("%s restriction is only supported on properly " + | ||
| "indexed columns. %s is not valid.", operator, relation); | ||
| } |
There was a problem hiding this comment.
I'm guessing this has been changed already in your not-yet-pushed work, but once LIKE doesn't return true from requiresIndexing(), seems like this change should no longer be necessary.
maedhroz
reviewed
Aug 9, 2025
| public static boolean matches(ByteBuffer buffer1, ByteBuffer buffer2) | ||
| { | ||
| return buffer1.equals(buffer2); | ||
| } |
There was a problem hiding this comment.
nit: I'd probably just inline this in Expression rather than having a one-line utility method.
maedhroz
reviewed
Aug 9, 2025
| @@ -268,6 +287,10 @@ public boolean isSatisfiedBy(ByteBuffer columnValue) | |||
|
|
|||
| if (lower != null) | |||
| { | |||
| // Post-filtering for LIKE operators must be consistent with implementation of LIKE operators in non-SAI Allow Filtering path | |||
| if(operator.isLikeVariant()) | |||
| return termMatches(value.raw, lower.value.raw); | |||
There was a problem hiding this comment.
I think we still may need to account for things like case-insensitive search eventually, so we should be able to just fall through to validateStringValue(), which would just call termMatches() anyway?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CASSANDRA-17198 Support for LIKE expression as PostFilter in SAI
Since LIKE is filtered in post filter, ALLOW FILTERING is required. I tested it with some basic queries. Will do further manual testing + unit tests. It would be helpful for early reviews.
patch by Pranav Shenoy; reviewed by Caleb Rackliffe for CASSANDRA-17198