Replay nondurable #4264
Open
Replay nondurable #4264
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
belliottsmith
force-pushed
the
replay-nondurable
branch
2 times, most recently
from
c6ba404 to
831de21
Compare
ifesdjeen
approved these changes
Jul 22, 2025
|
|
||
| public class AccordDataStore implements DataStore | ||
| { | ||
| private static final Logger logger = LoggerFactory.getLogger(AccordDataStore.class); |
There was a problem hiding this comment.
Could you briefly document durability semantics here? In other words, the fact that sync point is executed after we have flushed meltable?
| @@ -78,35 +68,42 @@ public boolean hasTasks() | |||
| return tasks + executor.getActiveTaskCount() + executor.getPendingTaskCount() > 0; | |||
| } | |||
|
|
|||
| @Override | |||
| void preUnlockCaches() | |||
There was a problem hiding this comment.
nit: maybe "before" instead of "pre"?
| @@ -492,6 +492,8 @@ void initParent() | |||
| @Override | |||
| public void close() | |||
| { | |||
| // TODO (required): validate this in IntervalBTreeTest | |||
| public static class UniqueSave | ||
| { | ||
| @Nullable List<Runnable> onSuccess; | ||
| void onSuccess(Runnable onSuccess) |
There was a problem hiding this comment.
It looks like onSuccess can be called from multiple threads (via shared executor submission), should we use volatile and some concurrent structure here?
There was a problem hiding this comment.
It's all done under mutual exclusion while holding the executor lock.
|
|
||
| T listener; | ||
| if (null == (listener = (T)onFlush.get(key))) | ||
| onFlush = ImmutableMap.<Object, Consumer<TableMetadata>>builder().putAll(onFlush).put(key, listener = factory.get()).build(); |
There was a problem hiding this comment.
Would you mind if we not used assignments inside statements (it is just so easy to miss them), and did something like this:
T listener = (T) onFlush.get(key);
if (listener == null)
{
listener = factory.get();
onFlush = ImmutableMap.<Object, Consumer<TableMetadata>>builder()
.putAll(onFlush)
.put(key, listener)
.build();
}
return listener;
Patch by Alex Petrov; reviewed by Benedict Elliott Smith for CASSANDRA-20765
Patch by Alex Petrov; reviewed by Benedict Elliott Smith for CASSANDRA-20767
belliottsmith
force-pushed
the
replay-nondurable
branch
from
65268f2 to
02793b7
Compare
…tore and data store Also fix: - Limit truncation to TruncatedApplyWithOutcome until data is persisted durably to local store - IntervalUpdater not invoking super.close() - Do not invoke preRunExclusive without holding lock - IntervalUpdater not correctly initialise BranchBuilder.inUse - AccordExecutor should notify if more work on unlock of caches - Relax paranoid CFK validation during restart Also improve: - Flush logs before System.exit - Start/stop progress log explicitly - Limit progress log concurrency - Clear heavy fields in some messages once processed patch by Benedict; reviewed by Alex Petrov for CASSANDRA-20780
belliottsmith
force-pushed
the
replay-nondurable
branch
from
02793b7 to
0b80935
Compare
belliottsmith
force-pushed
the
trunk
branch
3 times, most recently
from
df3eb40 to
54e39a9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks for sending a pull request! Here are some tips if you're new here:
Commit messages should follow the following format:
The Cassandra Jira