Skip to content

feat: fix bug in Postgres dialect where if a table already exists then it would give error (Invalid query)#58

Merged
hsluoyz merged 1 commit into
apache:masterfrom
vishal-bihani:master
Aug 16, 2023
Merged

feat: fix bug in Postgres dialect where if a table already exists then it would give error (Invalid query)#58
hsluoyz merged 1 commit into
apache:masterfrom
vishal-bihani:master

Conversation

@vishal-bihani
Copy link
Copy Markdown
Contributor

Current version of Xorm in this adapter has a bug in Postgres dialect where if a table already exists then it would give error (Invalid query)

Screenshot 2023-08-16 at 5 05 10 PM

For your reference: https://gitea.com/xorm/xorm/pulls/1779

Updating the Xorm dependency resolved the issue.

@casbin-bot
Copy link
Copy Markdown

@tangyang9464 @JalinWang @imp2002 please review

@CLAassistant
Copy link
Copy Markdown

CLAassistant commented Aug 16, 2023

CLA assistant check
All committers have signed the CLA.

@coveralls
Copy link
Copy Markdown

Coverage Status

coverage: 70.737%. remained the same when pulling cd3fd77 on vishal-bihani:master into 2bfc453 on casbin:master.

@hsluoyz hsluoyz changed the title Fix: Invalid PG query feat: fix bug in Postgres dialect where if a table already exists then it would give error (Invalid query) Aug 16, 2023
@hsluoyz hsluoyz merged commit 047522b into apache:master Aug 16, 2023
@github-actions
Copy link
Copy Markdown

🎉 This PR is included in version 3.1.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants