Skip to content

Conversation

pitrou
Copy link
Member

@pitrou pitrou commented Jul 9, 2025

Rationale for this change

The system package for xsimd is too old on Fedora 39, use bundled version instead.

Are these changes tested?

By existing CI jobs.

Are there any user-facing changes?

No.

The system package for xsimd is too old on Fedora 39, use bundled version instead.
@pitrou
Copy link
Member Author

pitrou commented Jul 9, 2025

@github-actions crossbow submit fedora

@github-actions github-actions bot added the awaiting review Awaiting review label Jul 9, 2025
Copy link

github-actions bot commented Jul 9, 2025

Revision: 5862288

Submitted crossbow builds: ursacomputing/crossbow @ actions-1c7595d074

Task Status
example-python-minimal-build-fedora-conda GitHub Actions
test-fedora-39-cpp GitHub Actions
test-fedora-39-python-3 GitHub Actions

@pitrou pitrou marked this pull request as ready for review July 9, 2025 11:30
Copy link
Member

@raulcd raulcd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I've validated the linux-packaging jobs for almalinux-10 where we also use the system xsimd-devel. Those use a newer version as those are successful for the latest nightly:
https://github.com/ursacomputing/crossbow/actions/runs/16164526221

@github-actions github-actions bot added awaiting merge Awaiting merge and removed awaiting review Awaiting review labels Jul 9, 2025
@pitrou pitrou merged commit 5b0a001 into apache:main Jul 9, 2025
33 of 34 checks passed
@pitrou pitrou removed the awaiting merge Awaiting merge label Jul 9, 2025
@pitrou pitrou deleted the gh47037-fedora branch July 9, 2025 14:43
Copy link

After merging your PR, Conbench analyzed the 4 benchmarking runs that have been run so far on merge-commit 5b0a001.

There were no benchmark performance regressions. 🎉

The full Conbench report has more details. It also includes information about 58 possible false positives for unstable benchmarks that are known to sometimes produce them.

amoeba pushed a commit that referenced this pull request Jul 10, 2025
### Rationale for this change

The system package for xsimd is too old on Fedora 39, use bundled version instead.

### Are these changes tested?

By existing CI jobs.

### Are there any user-facing changes?

No.
* GitHub Issue: #47037

Authored-by: Antoine Pitrou <[email protected]>
Signed-off-by: Antoine Pitrou <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants