-
Notifications
You must be signed in to change notification settings - Fork 3.8k
GH-46989: [CI][R] Use Ubuntu 20.04 instead of OpenSUSE for R 4.1 #46990
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@github-actions crossbow submit test-r-rstudio-r-base-* |
|
Revision: c2d4d46 Submitted crossbow builds: ursacomputing/crossbow @ actions-e1fe36eccc
|
Hmm... They don't work...
|
@github-actions crossbow submit test-r-rstudio-r-base-* |
Revision: 7d9bf79 Submitted crossbow builds: ursacomputing/crossbow @ actions-c0bd9ba83d
|
I'm strongly in favor of requiring GCC 9. We recently reached consensus in favor of switching to C++20, so we will need at least that version anyway. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1
This should be fine as far as CRAN goes. Left one comment about splitting this into two PRs for better visibility about the gcc 7.1 -> 9 change.
I'll merge this for 21.0.0 release. |
After merging your PR, Conbench analyzed the 4 benchmarking runs that have been run so far on merge-commit 27cca0f. There were no benchmark performance regressions. 🎉 The full Conbench report has more details. It also includes information about 30 possible false positives for unstable benchmarks that are known to sometimes produce them. |
) ### Rationale for this change OpenSUSE 15.5 ships old GCC (7.5) that doesn't have enough C++17 support. ### What changes are included in this PR? Use Ubuntu 20.04 that ships GCC 9.3 instead of OpenSUSE 15.5. Ubuntu 20.04 reached EOL but we can use it for now. We discussed why we need OpenSUSE 15.5 based job at #45718 (comment) . We have the job because https://arrow.apache.org/docs/developers/cpp/building.html said "gcc 7.1 and higher should be sufficient". We need require GCC 9 or later with #46813. ### Are these changes tested? Yes. ### Are there any user-facing changes? No. * GitHub Issue: #46989 Lead-authored-by: Sutou Kouhei <[email protected]> Co-authored-by: Sutou Kouhei <[email protected]> Signed-off-by: Sutou Kouhei <[email protected]>
Rationale for this change
OpenSUSE 15.5 ships old GCC (7.5) that doesn't have enough C++17 support.
What changes are included in this PR?
Use Ubuntu 20.04 that ships GCC 9.3 instead of OpenSUSE 15.5.
Ubuntu 20.04 reached EOL but we can use it for now.
We discussed why we need OpenSUSE 15.5 based job at #45718 (comment) . We have the job because https://arrow.apache.org/docs/developers/cpp/building.html said "gcc 7.1 and higher should be sufficient".
We need require GCC 9 or later with #46813.
Are these changes tested?
Yes.
Are there any user-facing changes?
No.