GH-46745: [C++] Update bundled Boost to 1.88.0 and Apache Thrift to 0.22.0 #46912
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
@github-actions crossbow submit -g cpp -g r -g python -g linux |
This comment was marked as outdated.
This comment was marked as outdated.
kou
force-pushed
the
cpp-boost
branch
15 times, most recently
from
7cc8462 to
87feab0
Compare
kou
force-pushed
the
cpp-boost
branch
8 times, most recently
from
7544ecb to
e26a807
Compare
kou
requested review from
assignUser,
jonkeane,
raulcd,
lidavidm and
westonpace
as code owners
raulcd
reviewed
Jul 7, 2025
|
@github-actions crossbow submit -g cpp -g r -g python -g linux |
github-actions
bot
added
awaiting change review
|
Revision: 3e7126e Submitted crossbow builds: ursacomputing/crossbow @ actions-73cd498af8
|
|
FYI: This will reduce Apache Thrift download related CI failures because this uses the latest Apache Thrift. |
The iceberg-cpp project is seeing frequent CI failures due to issues downloading Apache Thrift as part of Arrow's setup. So +1. |
github-actions
bot
added
awaiting merge
|
Let's add this to 21.0.0 to reduce CI failures. It'll reduce 21.0.0 release costs. (We don't need to re-run jobs several times...) |
zhjwpku
added a commit
to zhjwpku/iceberg-cpp
that referenced
this pull request
Jul 8, 2025
The commit includes apache/arrow#46912, which are resolve our frequent CI failures.
amoeba
pushed a commit
that referenced
this pull request
Jul 8, 2025
….22.0 (#46912) ### Rationale for this change Bundled Boost 1.81.0 and Apache Thrift 0.22.0 are old. It's difficult to upgrade only Boost because Apache Thrift depends on Boost. So this PR updates bundled Boost and Apache Thrift. ### What changes are included in this PR? * Update bundled Boost: * Use CMake based build instead of b2 * Use FetchContent not ExternalProject * Stop using our trimmed Boost source archive * Update bundled Apache Thrift: * Use FetchContent not ExternalProject ### Are these changes tested? Yes. ### Are there any user-facing changes? Yes. * GitHub Issue: #46745 * GitHub Issue: #46740 Authored-by: Sutou Kouhei <[email protected]> Signed-off-by: Raúl Cumplido <[email protected]>
|
After merging your PR, Conbench analyzed the 4 benchmarking runs that have been run so far on merge-commit f12356a. There were no benchmark performance regressions. 🎉 The full Conbench report has more details. It also includes information about 14 possible false positives for unstable benchmarks that are known to sometimes produce them. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale for this change
Bundled Boost 1.81.0 and Apache Thrift 0.22.0 are old.
It's difficult to upgrade only Boost because Apache Thrift depends on Boost. So this PR updates bundled Boost and Apache Thrift.
What changes are included in this PR?
Are these changes tested?
Yes.
Are there any user-facing changes?
Yes.