Skip to content

Conversation

kou
Copy link
Member

@kou kou commented Jun 18, 2025

Rationale for this change

AWS SDK for C++ related products don't support unity build.

What changes are included in this PR?

Always disable unity build only for AWS SDK for C++ related products.

Are these changes tested?

Yes.

Are there any user-facing changes?

No.

Copy link

⚠️ GitHub issue #46843 has been automatically assigned in GitHub to PR creator.

@raulcd
Copy link
Member

raulcd commented Jun 19, 2025

@github-actions crossbow submit test-debian-12-docs

Copy link

Revision: daccbbe

Submitted crossbow builds: ursacomputing/crossbow @ actions-6d8783d78f

Task Status
test-debian-12-docs GitHub Actions

Copy link
Member

@raulcd raulcd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 this is fixing our current issue. Is AWS SDK supposed to support it? Should we open an issue upstream?

@github-actions github-actions bot added awaiting merge Awaiting merge and removed awaiting committer review Awaiting committer review labels Jun 19, 2025
@kou
Copy link
Member Author

kou commented Jun 20, 2025

I think that AWS SDK for C++ doesn't care about unity build. So it doesn't support unity build isn't strange.
So we don't need to open an issue to upstream.

@kou kou merged commit 5f0aeb5 into apache:main Jun 20, 2025
37 of 38 checks passed
@kou kou removed the awaiting merge Awaiting merge label Jun 20, 2025
@kou kou deleted the cpp-aws-sdk-cpp-unity branch June 20, 2025 01:10
Copy link

After merging your PR, Conbench analyzed the 3 benchmarking runs that have been run so far on merge-commit 5f0aeb5.

There were 119 benchmark results with an error:

There were no benchmark performance regressions. 🎉

The full Conbench report has more details.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants