-
Notifications
You must be signed in to change notification settings - Fork 3.8k
GH-46724: [C++][Parquet] OSSFuzz: Prevent from Bad-cast in handling statistics #46725
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
e5a558e
to
6abdcdb
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for fixing this. Can you first add the regression file to arrow-testing/data/parquet/fuzzing/
?
@mapleFU Would you like to update this PR? |
Sorry, I was really busy with apartment hunting for a while. I'll update it today |
test case: apache/arrow-testing#105 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, can you just update the parquet-testing submodule?
No problem (and I hope the apartment hunting went well)! |
@pitrou updated |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1, thanks a lot for fixing this @mapleFU
After merging your PR, Conbench analyzed the 3 benchmarking runs that have been run so far on merge-commit 19fb7bb. There was 1 benchmark result indicating a performance regression:
The full Conbench report has more details. |
Rationale for this change
See issue
What changes are included in this PR?
Checked before a cast here
Are these changes tested?
no
Are there any user-facing changes?
no