Skip to content

Conversation

mapleFU
Copy link
Member

@mapleFU mapleFU commented Jun 5, 2025

Rationale for this change

See issue

What changes are included in this PR?

Checked before a cast here

Are these changes tested?

no

Are there any user-facing changes?

no

@mapleFU mapleFU requested a review from wgtmac as a code owner June 5, 2025 17:22
Copy link

github-actions bot commented Jun 5, 2025

⚠️ GitHub issue #46724 has been automatically assigned in GitHub to PR creator.

@mapleFU mapleFU force-pushed the try-to-fix-ubsan-issue branch from e5a558e to 6abdcdb Compare June 5, 2025 17:23
@mapleFU mapleFU changed the title GH-46724: [C++][Parquet] Prevent from Bad-cast in handling statistics GH-46724: [C++][Parquet] OSSFuzz: Prevent from Bad-cast in handling statistics Jun 5, 2025
Copy link
Member

@pitrou pitrou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this. Can you first add the regression file to arrow-testing/data/parquet/fuzzing/?

@github-actions github-actions bot added awaiting committer review Awaiting committer review and removed awaiting review Awaiting review labels Jun 9, 2025
@pitrou
Copy link
Member

pitrou commented Jun 19, 2025

@mapleFU Would you like to update this PR?

@mapleFU
Copy link
Member Author

mapleFU commented Jun 20, 2025

Sorry, I was really busy with apartment hunting for a while. I'll update it today

@mapleFU
Copy link
Member Author

mapleFU commented Jun 20, 2025

test case: apache/arrow-testing#105

Copy link
Member

@pitrou pitrou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, can you just update the parquet-testing submodule?

@pitrou
Copy link
Member

pitrou commented Jun 24, 2025

Sorry, I was really busy with apartment hunting for a while. I'll update it today

No problem (and I hope the apartment hunting went well)!

@mapleFU
Copy link
Member Author

mapleFU commented Jun 24, 2025

@pitrou updated

Copy link
Member

@pitrou pitrou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1, thanks a lot for fixing this @mapleFU

@pitrou pitrou merged commit 19fb7bb into apache:main Jun 24, 2025
34 checks passed
@pitrou pitrou removed the awaiting committer review Awaiting committer review label Jun 24, 2025
@github-actions github-actions bot added the awaiting committer review Awaiting committer review label Jun 24, 2025
@mapleFU mapleFU deleted the try-to-fix-ubsan-issue branch June 24, 2025 12:29
Copy link

After merging your PR, Conbench analyzed the 3 benchmarking runs that have been run so far on merge-commit 19fb7bb.

There was 1 benchmark result indicating a performance regression:

The full Conbench report has more details.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants