GH-45986: [C++] Update bundled GoogleTest #45996
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
github-actions
bot
added
Component: C++
awaiting committer review
kou
force-pushed
the
cpp-gtest
branch
2 times, most recently
from
a7bec63 to
c4aea3f
Compare
|
This is ready. |
raulcd
approved these changes
Apr 3, 2025
| @@ -210,7 +210,6 @@ jobs: | |||
| ARROW_WITH_SNAPPY: ON | |||
| ARROW_WITH_ZLIB: ON | |||
| ARROW_WITH_ZSTD: ON | |||
| GTest_SOURCE: BUNDLED | |||
There was a problem hiding this comment.
Note for self: next time we add something like this we probably want to add a comment on why we are adding it so we understand we can remove it later on. I didn't find a good enough reason on why it was added.
I had to go to a comment:
#14177 (comment)
and a commit to see where was this coming from:
1e33ad9
github-actions
bot
added
awaiting review
|
After merging your PR, Conbench analyzed the 4 benchmarking runs that have been run so far on merge-commit eaeb64b. There were no benchmark performance regressions. 🎉 The full Conbench report has more details. It also includes information about 17 possible false positives for unstable benchmarks that are known to sometimes produce them. |
lriggs
pushed a commit
to lriggs/arrow
that referenced
this pull request
Apr 15, 2025
### Rationale for this change The current bundle Google 1.11.0 was released in 2021. It's too old. ### What changes are included in this PR? Update to the latest GoogleTest: 1.16.0 ### Are these changes tested? Yes. ### Are there any user-facing changes? No. * GitHub Issue: apache#45986 Authored-by: Sutou Kouhei <[email protected]> Signed-off-by: Raúl Cumplido <[email protected]>
zanmato1984
pushed a commit
to zanmato1984/arrow
that referenced
this pull request
Apr 15, 2025
### Rationale for this change The current bundle Google 1.11.0 was released in 2021. It's too old. ### What changes are included in this PR? Update to the latest GoogleTest: 1.16.0 ### Are these changes tested? Yes. ### Are there any user-facing changes? No. * GitHub Issue: apache#45986 Authored-by: Sutou Kouhei <[email protected]> Signed-off-by: Raúl Cumplido <[email protected]>
zanmato1984
pushed a commit
to zanmato1984/arrow
that referenced
this pull request
Apr 15, 2025
### Rationale for this change The current bundle Google 1.11.0 was released in 2021. It's too old. ### What changes are included in this PR? Update to the latest GoogleTest: 1.16.0 ### Are these changes tested? Yes. ### Are there any user-facing changes? No. * GitHub Issue: apache#45986 Authored-by: Sutou Kouhei <[email protected]> Signed-off-by: Raúl Cumplido <[email protected]>
assignUser
pushed a commit
that referenced
this pull request
Apr 22, 2025
### Rationale for this change The current bundle Google 1.11.0 was released in 2021. It's too old. ### What changes are included in this PR? Update to the latest GoogleTest: 1.16.0 ### Are these changes tested? Yes. ### Are there any user-facing changes? No. * GitHub Issue: #45986 Authored-by: Sutou Kouhei <[email protected]> Signed-off-by: Raúl Cumplido <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale for this change
The current bundle Google 1.11.0 was released in 2021. It's too old.
What changes are included in this PR?
Update to the latest GoogleTest: 1.16.0
Are these changes tested?
Yes.
Are there any user-facing changes?
No.