fix: Add fields to Error::NotImplemented with more details on what isn't implemented
#575
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kylebarron
approved these changes
Dec 12, 2025
alamb
changed the title
Error::NotImplemented with more details on what isn't implemented
Contributor
|
Thank you @carols10cents and @kylebarron |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
NotImplementederror should say what method wasn't implemented by what implementation #572.Rationale for this change
When a user has lots of uses of object_store and one of them is returning
object_store::Error::NotImplemented, provide more information to make debugging easier.What changes are included in this PR?
I added 2 fields to
NotImplemented: a description of what operation isn't implemented and which implementation is returning this.Are there any user-facing changes?
This is a breaking change to the public API of the
object_store::Errortype.Because of the additional fields on the error variant, if anyone is matching on this variant, they'll likely have to update their code. If any implementers of this trait are returning this error, they'll have to update their construction of this variant.