Skip to content

chore: Check format in CI#20

Merged
kou merged 2 commits intoapache:mainfrom
kou:format
Aug 26, 2025
Merged

chore: Check format in CI#20
kou merged 2 commits intoapache:mainfrom
kou:format

Conversation

@kou
Copy link
Copy Markdown
Member

@kou kou commented Aug 25, 2025

What's Changed

Run dotnet format via pre-commit.

This excludes src/Apache.Arrow/Flatbuf/FlatBuffers/ because it's a bundled source codes.
See also: #18

Closes #2.

Assert.True(array.GetValue(7).HasValue);
Assert.True(array.GetValue(7).Value);
#pragma warning disable CS0618
#pragma warning disable CS0618
Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this OK?

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is fine. I'd probably prefer the original format with indent but it doesn't look like that's supported by dotnet format, although JetBrains Resharper has a custom extension to support this: https://www.jetbrains.com/help/resharper/EditorConfig_CSHARP_CSharpIndentStylePageSchema.html#resharper_csharp_indent_preprocessor_other

Assert.True(array.GetValue(7).HasValue);
Assert.True(array.GetValue(7).Value);
#pragma warning disable CS0618
#pragma warning disable CS0618
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is fine. I'd probably prefer the original format with indent but it doesn't look like that's supported by dotnet format, although JetBrains Resharper has a custom extension to support this: https://www.jetbrains.com/help/resharper/EditorConfig_CSHARP_CSharpIndentStylePageSchema.html#resharper_csharp_indent_preprocessor_other

Co-authored-by: Adam Reeve <adreeve@gmail.com>
@kou kou merged commit 243f1b7 into apache:main Aug 26, 2025
4 checks passed
@kou kou deleted the format branch August 26, 2025 00:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Configure code formatting check in CI

2 participants