fix: can not get hostname in redhat #12267
Merged
+52
−11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dosubot
bot
added
size:M
|
Hi @xuruidong, can you create an issue first and include minimal steps to reproduce it? |
done |
bzp2010
reviewed
May 31, 2025
bzp2010
previously approved these changes
Jun 9, 2025
|
Hi @xuruidong, please fix failed ci |
Baoyuantop
reviewed
Jul 21, 2025
t/core/utils.t
Outdated
| ngx.say("hostname: ", hostname) | ||
| local hostname2 = core.utils.gethostname() | ||
| ngx.say("hostname cached: ", hostname == hostname2) | ||
| ngx.say("hostname valid: ", hostname ~= "" and (hostname ~= "unknown" or true)) |
There was a problem hiding this comment.
(hostname ~= "unknown" or true) always evaluates to true.
There was a problem hiding this comment.
Hi @xuruidong, please have a look.
There was a problem hiding this comment.
@Baoyuantop ,please review this. Thank you.
Baoyuantop
added
the
wait for update
Signed-off-by: xuruidong <[email protected]>
Baoyuantop
removed
the
wait for update
Baoyuantop
previously approved these changes
Jul 31, 2025
Baoyuantop
approved these changes
Aug 1, 2025
membphis
approved these changes
Aug 1, 2025
bzp2010
approved these changes
Aug 1, 2025
github-project-automation
bot
moved this from 👀 In review
to ✅ Done
in ⚡️ Apache APISIX Roadmap
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I use docker image apache/apisix:3.11.0-redhat , and get an error from the log: "sh: /bin/hostname: No such file or directory"
Which issue(s) this PR fixes:
Fixes #12270
Checklist