Skip to content

Conversation

yangyulely
Copy link
Contributor

Fixes: #49671
Key Changes:

  1. Enhanced Hook (TableauHook):

    • Added a get_job_details method that fetches the job's finish code, type, and the associated object's name and ID (Workbook, Datasource, or Flow). It returns this data as a dictionary.
  2. Improved Sensor (TableauJobStatusSensor):

    • The sensor now uses get_job_details to enrich its log messages.
    • Info Logs: Now include the job type and the object name/ID (e.g., Job type 'RefreshExtract' on MyWorkbook (id-123) has finishCode SUCCESS (0).).
    • Error Messages: Are no longer hardcoded to "Workbook." They now dynamically state the correct object type and name (e.g., The Tableau Refresh Datasource Job for 'MyData' failed!).
  3. Fixed Tests:

    • Unit tests were updated to mock the new get_job_details method, ensuring they align with the current implementation.

^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in airflow-core/newsfragments.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Pleae add the friendly name of objects in the log. Currently it only shows the Tableau ID's.
1 participant