-
Notifications
You must be signed in to change notification settings - Fork 15.5k
Add Catalan language to Airflow #55013
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Technical approval. Looks great! |
@bugraoz93 I didn't know who to ask so I sent a message to Jens since I know him from the Summit. Feel free to sponsor this translation! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
admin.json, assets.json, browse.json and common.json reviewed.
I will finnish the remaining ones later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Technical-wise looks good.
Locales and their files:
┏━━━━━━━━┳━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━┓
┃ Locale ┃ Files ┃
┡━━━━━━━━╇━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━┩
│ en │ assets.json, components.json, admin.json, dags.json, dashboard.json, browse.json, common.json, dag.json, hitl.json, tasks.json │
│ ca │ admin.json, assets.json, browse.json, common.json, components.json, dag.json, dags.json, dashboard.json, hitl.json, tasks.json │
└────────┴────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────┘
Summary of differences by language:
Translation Progress: ca
┏━━━━━━━━━━━━━━━━━┳━━━━━━━━━┳━━━━━━━┳━━━━━━━┳━━━━━━━━━━━━┳━━━━━━━┳━━━━━━━━━━┳━━━━━━━━━━━━┓
┃ File ┃ Missing ┃ Extra ┃ TODOs ┃ Translated ┃ Total ┃ Coverage ┃ Completion ┃
┡━━━━━━━━━━━━━━━━━╇━━━━━━━━━╇━━━━━━━╇━━━━━━━╇━━━━━━━━━━━━╇━━━━━━━╇━━━━━━━━━━╇━━━━━━━━━━━━┩
│ admin.json │ 0 │ 0 │ 0 │ 105 │ 105 │ 100.0% │ 100.0% │
├─────────────────┼─────────┼───────┼───────┼────────────┼───────┼──────────┼────────────┤
│ assets.json │ 0 │ 0 │ 0 │ 20 │ 20 │ 100.0% │ 100.0% │
├─────────────────┼─────────┼───────┼───────┼────────────┼───────┼──────────┼────────────┤
│ browse.json │ 0 │ 0 │ 0 │ 12 │ 12 │ 100.0% │ 100.0% │
├─────────────────┼─────────┼───────┼───────┼────────────┼───────┼──────────┼────────────┤
│ common.json │ 0 │ 0 │ 0 │ 233 │ 233 │ 100.0% │ 100.0% │
├─────────────────┼─────────┼───────┼───────┼────────────┼───────┼──────────┼────────────┤
│ components.json │ 0 │ 0 │ 0 │ 94 │ 94 │ 100.0% │ 100.0% │
├─────────────────┼─────────┼───────┼───────┼────────────┼───────┼──────────┼────────────┤
│ dag.json │ 0 │ 0 │ 0 │ 89 │ 89 │ 100.0% │ 100.0% │
├─────────────────┼─────────┼───────┼───────┼────────────┼───────┼──────────┼────────────┤
│ dags.json │ 0 │ 0 │ 0 │ 55 │ 55 │ 100.0% │ 100.0% │
├─────────────────┼─────────┼───────┼───────┼────────────┼───────┼──────────┼────────────┤
│ dashboard.json │ 0 │ 0 │ 0 │ 33 │ 33 │ 100.0% │ 100.0% │
├─────────────────┼─────────┼───────┼───────┼────────────┼───────┼──────────┼────────────┤
│ hitl.json │ 0 │ 0 │ 0 │ 21 │ 21 │ 100.0% │ 100.0% │
├─────────────────┼─────────┼───────┼───────┼────────────┼───────┼──────────┼────────────┤
│ tasks.json │ 0 │ 0 │ 0 │ 8 │ 8 │ 100.0% │ 100.0% │
├─────────────────┼─────────┼───────┼───────┼────────────┼───────┼──────────┼────────────┤
│ All files │ 0 │ 0 │ 0 │ 670 │ 670 │ 100.0% │ 100.0% │
└─────────────────┴─────────┴───────┴───────┴────────────┴───────┴──────────┴────────────┘
All translations are complete and consistent!
Can you please add the entries in .github/CODEOWNERS
as well such that sponsor and engaged translators are known?
Seems with me, @potiuk and @bugraoz93 you now have 3 options for a sponsor :-D |
This PR adds the Catalan language to Airflow. This is the Dev List thread.
@oscarhernandezrodriguez can you help me review it?
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rst
or{issue_number}.significant.rst
, in airflow-core/newsfragments.