Skip to content

Cleanup type ignores in apache/hive provider #53302

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Jul 15, 2025
+10 −8
Merged

Cleanup type ignores in apache/hive provider #53302

Changes from 6 commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
2a63050
Cleanup type ignores
mingdaoy Jul 13, 2025
b27f027
Update providers/apache/hive/src/airflow/providers/apache/hive/hooks/…
gopidesupavan Jul 13, 2025
35fd0a4
Fix as above to use get_conn_id()
jscheffl Jul 13, 2025
467c629
Merge branch 'apache:main' into 53241-cleanup-apache-hive
mingdaoy Jul 14, 2025
72595f8
Fix ci mypy checks incompatible signatures
mingdaoy Jul 14, 2025
a34573b
Merge branch 'apache:main' into 53241-cleanup-apache-hive
mingdaoy Jul 14, 2025
14853d9
Merge branch 'apache:main' into 53241-cleanup-apache-hive
mingdaoy Jul 14, 2025
c0ceac2
remove parameters
mingdaoy Jul 14, 2025
97730be
Re-add the parameters for mypy checks
mingdaoy Jul 15, 2025
44fbc89
Merge branch 'apache:main' into 53241-cleanup-apache-hive
mingdaoy Jul 15, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 10 additions & 8 deletions providers/apache/hive/src/airflow/providers/apache/hive/hooks/hive.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -865,7 +865,7 @@ def get_conn(self, schema: str | None = None) -> Any:
username: str | None = None
password: str | None = None

db = self.get_connection(self.hiveserver2_conn_id) # type: ignore
db = self.get_connection(self.get_conn_id())

auth_mechanism = db.extra_dejson.get("auth_mechanism", "NONE")
if auth_mechanism == "NONE" and db.login is None:
Expand Down Expand Up @@ -907,7 +907,7 @@ def _get_results(
with contextlib.closing(self.get_conn(schema)) as conn, contextlib.closing(conn.cursor()) as cur:
cur.arraysize = fetch_size or 1000

db = self.get_connection(self.hiveserver2_conn_id) # type: ignore
db = self.get_connection(self.get_conn_id())
# Not all query services (e.g. impala) support the set command
if db.extra_dejson.get("run_set_variable_statements", True):
env_context = get_context_from_env_var()
Expand Down Expand Up @@ -1029,9 +1029,10 @@ def get_records(
schema = kwargs["schema"] if "schema" in kwargs else "default"
return self.get_results(sql, schema=schema, hive_conf=parameters)["data"]

def _get_pandas_df( # type: ignore
def _get_pandas_df(
self,
sql: str,
sql,
parameters: list[Any] | tuple[Any, ...] | Mapping[str, Any] | None = None,
schema: str = "default",
hive_conf: dict[Any, Any] | None = None,
**kwargs,
Expand All @@ -1047,9 +1048,10 @@ def _get_pandas_df( # type: ignore
df = pd.DataFrame(res["data"], columns=[c[0] for c in res["header"]], **kwargs)
return df

def _get_polars_df( # type: ignore
def _get_polars_df(
self,
sql: str,
sql,
parameters: list[Any] | tuple[Any, ...] | Mapping[str, Any] | None = None,
schema: str = "default",
hive_conf: dict[Any, Any] | None = None,
**kwargs,
Expand All @@ -1076,7 +1078,7 @@ def get_df(
**kwargs: Any,
) -> pd.DataFrame: ...

@overload # type: ignore[override]
@overload
def get_df(
self,
sql: str,
Expand All @@ -1087,7 +1089,7 @@ def get_df(
**kwargs: Any,
) -> pl.DataFrame: ...

def get_df( # type: ignore
def get_df(
self,
sql: str,
schema: str = "default",
Expand Down