fix(hitl): Fix HITLEntryOperator "options" and "defaults" handling #53184
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lee-W
force-pushed
the
fix-hitl-entry-op-kwargs-handling
branch
from
9ed01fb to
2fe7032
Compare
Lee-W
force-pushed
the
fix-hitl-entry-op-kwargs-handling
branch
from
2fe7032 to
4c4a143
Compare
Only when both are not provided will they be set to ["OK"]
Lee-W
force-pushed
the
fix-hitl-entry-op-kwargs-handling
branch
from
4c4a143 to
bb26414
Compare
github-project-automation
bot
moved this from In review
to Done
in AIP-90 - Human in the loop
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
It's valid to set "defaults" to None while not providing
optionsWhat
Only when both are not provided will they be set to ["OK"]
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in airflow-core/newsfragments.