openlineage, mysql: add OpenLineage support for MySQL #31609
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JDarDagran
requested review from
potiuk,
ashb,
jedcunningham and
eladkal
as code owners
boring-cyborg
bot
added
area:dev-tools
area:providers
provider:common-sql
provider:DBs
provider:openlineage
|
@sunank200 could you please help review here? |
sunank200
reviewed
Jun 13, 2023
| "ordinal_position", | ||
| "column_type", | ||
| ], | ||
| normalize_name_method=lambda name: name.upper(), |
There was a problem hiding this comment.
is the name always supposed to be upper?
There was a problem hiding this comment.
tbh case sensitivity across different SQL databases is a bit problematic but so far we assumed so for MySQL in OpenLineage and I would not want to break it in this PR
Signed-off-by: Jakub Dardzinski <[email protected]>
mobuchowski
approved these changes
Jul 21, 2023
69 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds OpenLineage support for MySqlOperator.
depends on: #31398