Skip to content

Implement tracks context #94

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
aome510 merged 15 commits into from
Dec 25, 2022
Merged

Implement tracks context #94

aome510 merged 15 commits into from
Dec 25, 2022

Conversation

@aome510
Copy link
Owner

@aome510 aome510 commented Dec 24, 2022 •
edited
Loading

Overview

This PR adds new context type Tracks that should replace the use of tracks page and related structs. One benefit this change brings is that it allows to unify the handling codes for a tracks page and a context page, hence making the codes cleaner and easier to manage.

Changes

  • added structs/functions representing "tracks" context page's functionalities
  • removed structs/functions representing "tracks" page's functionalities
  • refactor command handling codes for context pages

aome510 added 13 commits December 23, 2022 22:27
@aome510
remove tracks page related structs and create new tracks context rela…
10dda9d 
…ted structs
@aome510
handle rendering for tracks context page
ee941df
@aome510
refactor PlayRandom command and ordering commands handler codes
ad830ec
@aome510
add TrackId constants for some "tracks" contexts
7ff4dda
@aome510
cleanup create_new_radio_page uses
65128dc
@aome510
add kind field to TracksId
79b0599
@aome510
fix compile error in client codes
e1c9a4d
@aome510
add once_cell and use it to construct global constant variables
30151e5
@aome510
use static instead of const when constructing `once_cell::Lazy<Tr…
ede65e5 
…acksId>`
@aome510
modify GetRadioTracks structure
a2b4681
@aome510
remove name field from TracksId and add it as desc field in `Co…
6847bba 
…ntext::Tracks`
@aome510
update how context description message is created
2bbb843
@aome510
remove finished TODO and add new TODO about liked tracks page
71d4f67
@aome510 aome510 mentioned this pull request Dec 24, 2022
Closed
@aome510 aome510 merged commit 7357088 into master Dec 25, 2022
@aome510 aome510 deleted the add-tracks-context branch January 30, 2023 01:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@aome510