Fixed Audio Issues and Login5 token #807
Closed
+541
−1,044
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Forgot to run cargo fmt - should be able to pass the checks now. |
Owner
I want to make some changes but couldn't push to your fork. Do you have Allow edits by maintainers enabled? Otherwise, I will create a separate PR myself |
Contributor
Author
|
Yes, Allow edits by maintainers is turned on for this PR. I submitted another commit fixing the formatting issues, maybe that is the issue? |
Contributor
Author
|
Owner
|
hmm thanks for the clarification. Maybe something wrong on my end. Let's me try again |
Owner
|
Sorry I couldn't figure it out so have to open a separate PR. I guess it has something to do with branch protection rule on the |
Contributor
Author
|
All good! |
KUHLwasStolen
added a commit
to KUHLwasStolen/spotify-player
that referenced
this pull request
Aug 26, 2025
* Upgrade `librespot` to `0.7.0`, fixing audio, authentication, DNS lookup issues (aome510#808) Resolves aome510#802 Resolves aome510#799 Resolves aome510#796 Resolves aome510#787 This PR was based on aome510#807 with a few updates --------- Co-authored-by: Bradley Zylstra <[email protected]> * Make Spotify Connect integration work with new authentication changes (aome510#809) Resolves aome510#804 - define a custom client to get user's available devices for Spotify Connect integration - update `client_id` general config to be optional + setting one will enable "user-provided client integration" which is requred for Spotify Connect feature - cleanup authentication codes - update documentation --------- Co-authored-by: Thang Pham <[email protected]> Co-authored-by: Bradley Zylstra <[email protected]>
tojamrok
pushed a commit
to tojamrok/spotify-player
that referenced
this pull request
Sep 3, 2025
…kup issues (aome510#808) Resolves aome510#802 Resolves aome510#799 Resolves aome510#796 Resolves aome510#787 This PR was based on aome510#807 with a few updates --------- Co-authored-by: Bradley Zylstra <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the login authentication issue #802 and pulls in some audio fixes for #796 from @KUHLwasStolen patch https://github.com/KUHLwasStolen/spotify-player/tree/librespot-temporary-hotfix. @KUHLwasStolen can do a PR to integrate his changes first.