Create app.toml with default values if it doesn't exist #221
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
create app.toml with default values if it doesn't already exist Closes: 182
create constructors for other themes for consistency Closes: 182
aome510
reviewed
Jul 18, 2023
spotify_player/src/state/mod.rs
Outdated
| pub use ui::*; | ||
|
|
||
| use crate::config; | ||
| use crate::config::{self}; |
Owner
There was a problem hiding this comment.
This is a weird import. Is it different from use crate::config?
Contributor
Author
There was a problem hiding this comment.
Think this happened as I imported AppConfig directly at some stage e.g. use crate::config::{self, AppConfig}.
Reverted anyway 👍
aome510
reviewed
Jul 18, 2023
aome510
reviewed
Jul 18, 2023
spotify_player/src/config/mod.rs
Outdated
| // parses configurations from an application config file in `path` folder, | ||
| // then updates the current configurations accordingly. | ||
| pub fn parse_config_file(&mut self, path: &Path) -> Result<()> { | ||
| fn parse_config_file(&mut self, path: &Path) -> Result<Option<()>> { |
Owner
There was a problem hiding this comment.
I would prefer returning Result<bool> and the function document should be updated with: "Returns false if no config file found and true otherwise".
aome510
requested changes
Jul 18, 2023
Owner
aome510
left a comment
aome510
left a comment
There was a problem hiding this comment.
Thanks for looking into this. Look good! Only need a few changes.
better constructor comment Co-authored-by: Thang Pham <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If an application configuration file is not found, one will be created with default values in the config directory.
The configs have been refactored to use
newconstructors instead of default implementations.closes #182