Skip to content

Conversation

@aome510
Copy link
Owner

@aome510 aome510 commented May 15, 2023

Resolves #150

Summary

This PR adds new changes that make spotify_player more robust to network errors, which allows the application to re-initialize a new Spotify session and reconnect to a new streaming connection after the network errors are resolved.

Changes

  • make the client/application more robust to network errors by
    • re-authenticating and initializing a new session if invalid before handling any client requests
    • creating/connecting to a new streaming connection upon a session re-authentication
    • avoiding panics in third-party codes
  • update how the application creates a new streaming connection
  • update client socket's result/error sending logic
  • update the authentication codes to allow code reuse and better error messages
  • disable logging when handling CLI commands

@aome510 aome510 marked this pull request as ready for review May 16, 2023 19:23
@aome510 aome510 merged commit 3bba942 into master May 16, 2023
@aome510 aome510 deleted the make_client_more_robust branch May 16, 2023 19:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

RSpotify de-authenticates after some time

2 participants