Skip to content

Extend CLI functionalities #194

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
aome510 merged 18 commits into from
May 10, 2023
Merged

Extend CLI functionalities #194

aome510 merged 18 commits into from
May 10, 2023

Conversation

@aome510
Copy link
Owner

@aome510 aome510 commented May 8, 2023 •
edited
Loading

Resolves #184

Changes

  • added more subcommands for playback start command: playback start context|liked|radio
  • added support for specifying either id or name for a Spotify item as a command's argument
  • added new commands:
    • playback like
    • connect
  • sent error messages back to socket handling get commands upon errors
  • updated playback volume command to support increasing/decreasing volume by an offset

aome510 added 15 commits May 8, 2023 13:23
@aome510
add --offset to playback volume command
de74677
@aome510
add add_context_args helper function
f1b67ac
@aome510
rename cli::socket to cli::client
ce47547
@aome510
updated handlers for commands involving context to use new Context …
ba68788 
…struct
@aome510
updated handling code for GetContext command
158dc81
@aome510
handle bad request with get command
f5718fa
@aome510
updated handling codes for Command::Start
a28ba04
@aome510
rename ContextId to IdOrName to re-use the struct
e0dfb83
@aome510
add connect subcommand and its handler
64ef5b1
@aome510
implement cli command to start liked tracks playback
5aee65c
@aome510
add add_id_or_name_group helper function
e9ed719
@aome510
implement command handler for "playback start radio" command
9069ae1
@aome510
refactor get Spotify ID code to use ItemType instead of ContextType
74c7534
@aome510
implement client handler for start radio command
5613ff3
@aome510
implement playback like cli command
e203d11
@aome510 aome510 marked this pull request as ready for review May 10, 2023 21:19
@aome510 aome510 merged commit cae6ca7 into master May 10, 2023
@aome510 aome510 deleted the extend-cli-func branch May 10, 2023 21:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Extend CLI Functionality

2 participants

@aome510