Wrong image rendering aspect ratio in Kitty

[LukeZBaker]

Hi

I really like spotify-player. From my brief testing I think it's probably the best command-line Spotify client and fully warrants my star!

I have compiled the program with a few extras like image rendering which display as high res graphics in Kitty. But the images are displayed in the wrong aspect ratio in Kitty. They display in the correct aspect ratio in WezTerm but that terminal emulator seems to use a lot more CPU cycles when running spotify-player than Kitty does.

Just as an aside, are there keyboard shortcuts to jump forward and back in a track? I know there's mouse support to do this, but is it possible with the keyboard too? The volume defaults to 50 which seems a strange default. I have fixed this with setting volume = 90 in [device] within app.toml but is there any reason why the default is low?

[aome510]

Hi @LukeZBaker,

I really like spotify-player. From my brief testing I think it's probably the best command-line Spotify client and fully warrants my star!

Thanks for the kind words. Really appreciate it :).

I have compiled the program with a few extras like image rendering which display as high res graphics in Kitty. But the images are displayed in the wrong aspect ratio in Kitty.

Do you have an example picture of the incorrect rendering in Kitty?

They display in the correct aspect ratio in WezTerm but that terminal emulator seems to use a lot more CPU cycles when running spotify-player than Kitty does

Does WezTerm also display image in high res?

Goes back to Kitty, I won't have access to Linux machine for a while, so I don't really have a way to test it now. The example in Image README section is a good reference on how Kitty should render.

Dig a bit deeper into the implementation detail, the way image rendering currently works is that an rectangle of size 5x9(*) is used to render. Terminals with high res support like Iterm2 or kitty will resize/stretch the image to fit into the above rectangle. So, the rendering aspect ratio may depend on the length/width of a cell provided by your terminal.

(*): why 5x9 by default though? It's just a value that works best based on my experience with my machines. Unfortunately, the render rectangle is not configurable atm, but it should be easy to support it.

Just as an aside, are there keyboard shortcuts to jump forward and back in a track? I know there's mouse support to do this, but is it possible with the keyboard too?

Currently, it's not supported, but should be an easy addition. Maybe something like "seek forward/backward by 5s" commands.

The volume defaults to 50 which seems a strange default. I have fixed this with setting volume = 90 in [device] within app.toml but is there any reason why the default is low?

Yeah, agree that it seems a bit strange =)). I vaguely remember the reason I set the value is playing safe to avoid music playing too loud on people's machine. FYI, I usually listen at 70-75, but maybe it's different for others and it also depends on their system's "sound" value.

[LukeZBaker]

Looking at the Image README section, I think the images there are also the wrong aspect ratio?

Here's how an album cover looks on WezTerm and Kitty respectively. WezTerm renders the image as a square, Kitty as a rectangle.

WezTerm

Kitty

Both are rendered in high-res.

Thanks for listening to my suggestions, I'll mention this when I write up my review. I'm happy to email you a link to the URL when published; don't want to spam it here.

[aome510]

@LukeZBaker,

Thanks for listening to my suggestions, I'll mention this when I write up my review. I'm happy to email you a link to the URL when published; don't want to spam it here.

Look forward to your blog!

(*): why 5x9 by default though? It's just a value that works best based on my experience with my machines. Unfortunately, the render rectangle is not configurable atm, but it should be easy to support it.

I've added layout configs in #75. The cover image's rectangle size should be configurable through cover_img_{width|length} options. You can try to tweak those settings (along with playback_window_width) to see if it can fix the wrong rendering ratio.

Currently, it's not supported, but should be an easy addition. Maybe something like "seek forward/backward by 5s" commands.

Implemented in #76. Default bindings: > for seek forward and < for seek backward.

Please lmk if something doesn't work.

[LukeZBaker]

Thanks, after testing I confirm #75 and #76 work well.

[aome510]

Thanks, after testing I confirm #75 and #76 work well.

Sounds good. I'll close this issue for now. Feel free to reopen it if encounter any issues.