DROID-3772 Navigation | Get rid of legacy isChatAllowed logic #2589
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR removes the legacy ChatConfig.isChatAllowed logic used in navigation flows and simplifies chat condition checks.
- Removed ChatConfig dependency and its usages in VaultViewModel, SplashViewModel, and SplashFragment.
- Updated navigation logic to rely solely on the existence of a chat value and UX type checks.
- Eliminated the legacy ChatConfig implementation from the configuration file.
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| presentation/src/main/java/com/anytypeio/anytype/presentation/vault/VaultViewModel.kt | Removed ChatConfig check and added debug logging for current space and chat details. |
| presentation/src/main/java/com/anytypeio/anytype/presentation/splash/SplashViewModel.kt | Removed ChatConfig condition in the navigation flow and streamlined the chat logic. |
| presentation/src/main/java/com/anytypeio/anytype/presentation/confgs/Confgs.kt | Removed legacy ChatConfig.isChatAllowed function and related configuration. |
| app/src/main/java/com/anytypeio/anytype/ui/splash/SplashFragment.kt | Removed ChatConfig usage in navigation blocks and simplified chat null checks. |
Comments suppressed due to low confidence (1)
app/src/main/java/com/anytypeio/anytype/ui/splash/SplashFragment.kt:175
- [nitpick] Ensure that the updated navigation condition (now checking only for a null chat) aligns with the intended user flow, and update existing tests if necessary to cover this behavior.
val chat = command.chat
presentation/src/main/java/com/anytypeio/anytype/presentation/vault/VaultViewModel.kt
Outdated
Show resolved
Hide resolved
…vault/VaultViewModel.kt Co-authored-by: Copilot <[email protected]>
uburoiubu
approved these changes
Jun 30, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
What type of PR is this? (check all applicable)
Related Tickets & Documents
Mobile & Desktop Screenshots/Recordings
Added tests?
Added to documentation?
[optional] Are there any post-deployment tasks we need to perform?