DROID-3746 Notifications | In-app settings + notifications permissions flow #2586
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
konstantiniiv
changed the title
There was a problem hiding this comment.
Pull Request Overview
This PR adds and integrates in-app notification permissions and notifications settings features while deprecating older vault introduction screens. Key changes include updates to the NotificationPermissionManager and its tests, integration of notification badge state into view models and UI components (such as the ProfileSettingsScreen and VaultScreen), and corresponding resource and dependency injection updates.
Reviewed Changes
Copilot reviewed 23 out of 23 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| NotificationPermissionManagerImplTest.kt | Updated tests to validate new dialog flag logic and permission state changes. |
| VaultViewModel.kt | Added notification permission monitoring logic to update badge state in the profile icon. |
| NotificationPermissionManager.kt | Revised permission dialog logic and added new methods for refreshing and checking notification state. |
| strings.xml, colors.xml, & Drawable Assets | Added new resources to support notification settings UI. |
| ProfileSettingsViewModel.kt & ProfileSettingsFragment.kt | Integrated notification permission manager to drive badge display and settings navigation. |
| VaultScreen.kt & VaultFragment.kt | Updated UI components to incorporate the notification badge based on permission status. |
| DI Files (VaultDI.kt, ProfileDI.kt) | Injected NotificationPermissionManager for new notifications flows. |
| Removal of IntroduceVaultScreen/Fragment | Deprecated screens related to vault introduction. |
Comments suppressed due to low confidence (1)
presentation/src/main/java/com/anytypeio/anytype/presentation/notifications/NotificationPermissionManager.kt:49
- It would be helpful to add a brief comment here explaining why the dialog is shown only if it has not been shown or dismissed, especially in light of previous count-based logic.
return when {
uburoiubu
approved these changes
Jun 30, 2025
konstantiniiv
deleted the
droid-3746-epic-release-12-ios-notifications-in-app-settings
branch
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
What type of PR is this? (check all applicable)
Related Tickets & Documents
Mobile & Desktop Screenshots/Recordings
Added tests?
Added to documentation?
[optional] Are there any post-deployment tasks we need to perform?