-
Notifications
You must be signed in to change notification settings - Fork 67
DROID-2966 Chats | Enhancement | Introduce MediaActivity + add in-app media player allowing screen rotation (MVP version) #2515
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR introduces the MediaActivity along with an in-app media player for videos and images while supporting screen rotation, enhancing the chats feature with media playback capabilities. Key changes include:
- Adding new dependency versions in the gradle libs configuration
- Propagating the new onRequestVideoPlayer callback through chat UI components
- Introducing MediaScreen, MediaActivity, and associated UI components for media playback
Reviewed Changes
Copilot reviewed 9 out of 9 changed files in this pull request and generated no comments.
Show a summary per file
File | Description |
---|---|
gradle/libs.versions.toml | Added media3 dependency versions |
feature-chats/ui/ChatScreen.kt | Added onRequestVideoPlayer parameter and forwarded calls |
feature-chats/ui/ChatPreviews.kt | Updated previews to pass the onRequestVideoPlayer callback |
feature-chats/ui/ChatBubble.kt | Added onRequestVideoPlayer parameter to Bubble composable and attachments |
feature-chats/ui/Attachments.kt | Refactored attachment handling and renamed a private helper function |
app/src/main/java/com/anytypeio/anytype/ui/media/screens/MediaScreen.kt | Added MediaScreen with ImageViewer and VideoPlayer composables |
app/src/main/java/com/anytypeio/anytype/ui/media/MediaActivity.kt | Introduced MediaActivity to launch MediaScreen |
app/src/main/java/com/anytypeio/anytype/ui/chats/ChatFragment.kt | Updated chat fragment to handle video playback via MediaActivity |
app/src/main/AndroidManifest.xml | Registered MediaActivity with orientation and screenSize configuration |
Comments suppressed due to low confidence (1)
app/src/main/java/com/anytypeio/anytype/ui/media/screens/MediaScreen.kt:347
- The standalone drag support modifier is not applied to an existing UI element, which means drag gestures on the DotScrubberSlider may never be detected. Consider chaining this modifier to the BoxWithConstraints modifier (or another appropriate parent) to enable the intended drag interaction.
Modifier.pointerInput(Unit) {
Description
What type of PR is this? (check all applicable)
Related Tickets & Documents
Mobile & Desktop Screenshots/Recordings
Added tests?
Added to documentation?
[optional] Are there any post-deployment tasks we need to perform?