-
Notifications
You must be signed in to change notification settings - Fork 67
DROID-3626 Space chat | Ui fixes + proper chat space creation #2508
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
konstantiniiv
merged 8 commits into
main
from
droid-3626-epic-new-space-type-chat-create-chat-space
Jun 6, 2025
Merged
DROID-3626 Space chat | Ui fixes + proper chat space creation #2508
konstantiniiv
merged 8 commits into
main
from
droid-3626-epic-new-space-type-chat-create-chat-space
Jun 6, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR implements UI fixes for the chat interface and adjusts the space creation workflow to properly support new use cases. Key changes include:
- Adding unread message and mention count fields in the chat preview.
- Refactoring space creation parameters across the presentation, middleware, and core models.
- Updating UI screens to utilize the revised space creation parameters and handle chat spaces differently.
Reviewed Changes
Copilot reviewed 10 out of 10 changed files in this pull request and generated no comments.
Show a summary per file
File | Description |
---|---|
presentation/src/main/java/com/anytypeio/anytype/presentation/vault/VaultViewModel.kt | Added unread message and unread mention counts to the chat preview data model. |
presentation/src/main/java/com/anytypeio/anytype/presentation/spaces/CreateSpaceViewModel.kt | Updated space creation parameters with new UX type and use case handling. |
middleware/src/main/java/com/anytypeio/anytype/middleware/mappers/ToMiddlewareModelMappers.kt | Introduced mapping for the new SpaceCreationUseCase enum. |
middleware/src/main/java/com/anytypeio/anytype/middleware/interactor/Middleware.kt | Modified space creation request to use the new use case conversion method. |
gallery-experience/src/main/java/com/anytypeio/anytype/gallery_experience/viewmodel/GalleryInstallationViewModel.kt | Adapted gallery installation space creation to include the new use case and UX type. |
domain/src/main/java/com/anytypeio/anytype/domain/spaces/CreateSpace.kt | Replaced the boolean flag with a use case parameter for space creation. |
core-models/src/main/java/com/anytypeio/anytype/core_models/ImportUseCase.kt | Added a new enum representing space creation use cases. |
core-models/src/main/java/com/anytypeio/anytype/core_models/Command.kt | Updated the CreateSpace command to use the new enum parameter. |
app/src/main/java/com/anytypeio/anytype/ui/vault/VaultScreen.kt | Adjusted VaultScreen for consistent styling and exposed new chat preview data. |
app/src/main/java/com/anytypeio/anytype/ui/spaces/CreateSpaceScreen.kt | Modified the creation button logic to support chat spaces under the new use case logic. |
uburoiubu
approved these changes
Jun 6, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
What type of PR is this? (check all applicable)
Related Tickets & Documents
Mobile & Desktop Screenshots/Recordings
Added tests?
Added to documentation?
[optional] Are there any post-deployment tasks we need to perform?