Skip to content

DROID-3626 Space chat | Ui fixes + proper chat space creation #2508

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

konstantiniiv
Copy link
Collaborator

@konstantiniiv konstantiniiv commented Jun 6, 2025


  • I understand that contributing to this repository will require me to agree with the CLA

Description

What type of PR is this? (check all applicable)

  • 🍕 Feature
  • 🐛 Bug Fix
  • 📝 Documentation Update
  • 🎨 Style
  • 🧑‍💻 Code Refactor
  • 🔥 Performance Improvements
  • ✅ Test
  • 🤖 Build
  • 🔁 CI

Related Tickets & Documents

Mobile & Desktop Screenshots/Recordings

Added tests?

  • 👍 yes
  • 🙅 no, because they aren't needed
  • 🙋 no, because I need help

Added to documentation?

  • 📜 README.md
  • 📓 tech-docs
  • 🙅 no documentation needed

[optional] Are there any post-deployment tasks we need to perform?

@konstantiniiv konstantiniiv self-assigned this Jun 6, 2025
@konstantiniiv konstantiniiv requested a review from uburoiubu as a code owner June 6, 2025 11:27
@konstantiniiv konstantiniiv requested a review from Copilot June 6, 2025 11:28
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR implements UI fixes for the chat interface and adjusts the space creation workflow to properly support new use cases. Key changes include:

  • Adding unread message and mention count fields in the chat preview.
  • Refactoring space creation parameters across the presentation, middleware, and core models.
  • Updating UI screens to utilize the revised space creation parameters and handle chat spaces differently.

Reviewed Changes

Copilot reviewed 10 out of 10 changed files in this pull request and generated no comments.

Show a summary per file
File Description
presentation/src/main/java/com/anytypeio/anytype/presentation/vault/VaultViewModel.kt Added unread message and unread mention counts to the chat preview data model.
presentation/src/main/java/com/anytypeio/anytype/presentation/spaces/CreateSpaceViewModel.kt Updated space creation parameters with new UX type and use case handling.
middleware/src/main/java/com/anytypeio/anytype/middleware/mappers/ToMiddlewareModelMappers.kt Introduced mapping for the new SpaceCreationUseCase enum.
middleware/src/main/java/com/anytypeio/anytype/middleware/interactor/Middleware.kt Modified space creation request to use the new use case conversion method.
gallery-experience/src/main/java/com/anytypeio/anytype/gallery_experience/viewmodel/GalleryInstallationViewModel.kt Adapted gallery installation space creation to include the new use case and UX type.
domain/src/main/java/com/anytypeio/anytype/domain/spaces/CreateSpace.kt Replaced the boolean flag with a use case parameter for space creation.
core-models/src/main/java/com/anytypeio/anytype/core_models/ImportUseCase.kt Added a new enum representing space creation use cases.
core-models/src/main/java/com/anytypeio/anytype/core_models/Command.kt Updated the CreateSpace command to use the new enum parameter.
app/src/main/java/com/anytypeio/anytype/ui/vault/VaultScreen.kt Adjusted VaultScreen for consistent styling and exposed new chat preview data.
app/src/main/java/com/anytypeio/anytype/ui/spaces/CreateSpaceScreen.kt Modified the creation button logic to support chat spaces under the new use case logic.

@konstantiniiv konstantiniiv merged commit 6343b80 into main Jun 6, 2025
3 checks passed
@konstantiniiv konstantiniiv deleted the droid-3626-epic-new-space-type-chat-create-chat-space branch June 6, 2025 11:36
@github-actions github-actions bot locked and limited conversation to collaborators Jun 6, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants