DROID-3704 Sentry | Release 11 #2471
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
uburoiubu
approved these changes
May 27, 2025
uburoiubu
approved these changes
May 27, 2025
There was a problem hiding this comment.
Pull Request Overview
This PR enhances font loading performance by switching to asynchronous font loading and improves notification channel group creation compatibility on certain devices.
- Added
FontLoadingStrategy.Asyncto all custom fonts in typography Compose files. - Wrapped
getNotificationChannelGroupin a try-catch to handleNoSuchMethodErroron some devices. - Updated onboarding typography file to use async loading for the Riccione font.
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| core-ui/src/main/java/com/anytypeio/anytype/core_ui/views/TypographyCompose.kt | Added loadingStrategy = FontLoadingStrategy.Async to all Font calls |
| core-ui/src/main/java/com/anyprotoio/anytype/core_ui/views/OnBoardingTypographyCompose.kt | Added async loading to fontRiccioneRegular; onboarding title style removed by mistake? |
| app/src/main/java/com/anytypeio/anytype/device/NotificationBuilder.kt | Wrapped channel group lookup in try-catch to guard against missing API |
Comments suppressed due to low confidence (1)
core-ui/src/main/java/com/anytypeio/anytype/core_ui/views/OnBoardingTypographyCompose.kt:13
- It looks like the
HeadlineOnBoardingTitleTextStyle declaration was accidentally removed in this diff. Please re-add theHeadlineOnBoardingTitledefinition to restore onboarding typography.
val fontRiccioneRegular = FontFamily(
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
What type of PR is this? (check all applicable)
Related Tickets & Documents
Mobile & Desktop Screenshots/Recordings
Added tests?
Added to documentation?
[optional] Are there any post-deployment tasks we need to perform?