Skip to content

DROID-2966 Chats | Fix | Misc. fixes #2452

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
May 24, 2025
Merged

Conversation

uburoiubu
Copy link
Member

No description provided.

@uburoiubu uburoiubu self-assigned this May 24, 2025
@uburoiubu uburoiubu requested a review from konstantiniiv as a code owner May 24, 2025 12:04
@uburoiubu uburoiubu requested a review from Copilot May 24, 2025 12:11
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR addresses various miscellaneous fixes in chats including UI adjustments and flow optimizations across presentation, domain, and data layers.

  • Added a debounce operator with a constant in the chat preview flow.
  • Introduced a subscribe method in the chat event channel and updated its usage.
  • Adjusted UI layout components in both widget and home screen for improved responsiveness.

Reviewed Changes

Copilot reviewed 7 out of 7 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
presentation/src/main/java/com/anytypeio/anytype/presentation/widgets/SpaceChatWidgetContainer.kt Added debounce and constant for chat flow updates.
domain/src/main/java/com/anytypeio/anytype/domain/chats/ChatPreviewContainer.kt Updated API call from observe to subscribe.
domain/src/main/java/com/anytypeio/anytype/domain/chats/ChatEventChannel.kt Added subscribe method to interface.
data/src/main/java/com/anytypeio/anytype/data/auth/event/ChatEventRemoteChannel.kt Implemented the subscribe method.
app/src/main/java/com/anytypeio/anytype/ui/widgets/types/SpaceChatWidget.kt Adjusted displayed unread count and added modifier padding.
app/src/main/java/com/anytypeio/anytype/ui/home/HomeScreenToolbar.kt Removed systemBarsPadding from toolbar modifier.
app/src/main/java/com/anytypeio/anytype/ui/home/HomeScreenFragment.kt Changed layout container and modified widget layout properties.
Comments suppressed due to low confidence (3)

domain/src/main/java/com/anytypeio/anytype/domain/chats/ChatEventChannel.kt:9

  • [nitpick] The parameter name 'subscribe' in the subscribe() method is ambiguous; consider renaming it to 'chatId' or 'id' for greater clarity.
fun subscribe(subscribe: Id): Flow<List<Event.Command.Chats>>

app/src/main/java/com/anytypeio/anytype/ui/home/HomeScreenToolbar.kt:43

  • [nitpick] Ensure the removal of systemBarsPadding is intentional, as it may affect the toolbar's layout on devices with varying system bar dimensions.
.systemBarsPadding()

app/src/main/java/com/anytypeio/anytype/ui/home/HomeScreenFragment.kt:118

  • [nitpick] Switching from a Box to a Column container and modifying the widget's layout modifier can fundamentally alter the layout behavior; please confirm these changes achieve the desired responsive design.
Column(

@uburoiubu uburoiubu merged commit 202cea4 into main May 24, 2025
3 checks passed
@uburoiubu uburoiubu deleted the droid-2966-misc-fixes-4 branch May 24, 2025 12:12
@github-actions github-actions bot locked and limited conversation to collaborators May 24, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants