Skip to content

DROID-3659 Multiplayer | Support link without approve, fixes #2445

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
May 23, 2025

Conversation

konstantiniiv
Copy link
Collaborator

@konstantiniiv konstantiniiv commented May 23, 2025


  • I understand that contributing to this repository will require me to agree with the CLA

Description

What type of PR is this? (check all applicable)

  • 🍕 Feature
  • 🐛 Bug Fix
  • 📝 Documentation Update
  • 🎨 Style
  • 🧑‍💻 Code Refactor
  • 🔥 Performance Improvements
  • ✅ Test
  • 🤖 Build
  • 🔁 CI

Related Tickets & Documents

Mobile & Desktop Screenshots/Recordings

Added tests?

  • 👍 yes
  • 🙅 no, because they aren't needed
  • 🙋 no, because I need help

Added to documentation?

  • 📜 README.md
  • 📓 tech-docs
  • 🙅 no documentation needed

[optional] Are there any post-deployment tasks we need to perform?

@konstantiniiv konstantiniiv self-assigned this May 23, 2025
@konstantiniiv konstantiniiv requested a review from uburoiubu as a code owner May 23, 2025 13:39
@konstantiniiv konstantiniiv requested a review from Copilot May 23, 2025 13:40
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes the multiplayer support link issue by adding cancellation support for join space requests and updating the UI to better handle request states. Key changes include:

  • Adding a new job (joinSpaceRequestJob) and corresponding cancel functionality in RequestJoinSpaceViewModel.
  • Updating UI screens to include a cancel button and a new "Join Space Request Sent" screen.
  • Adding new localization strings for request sent notifications.

Reviewed Changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.

File Description
presentation/src/main/java/com/anytypeio/anytype/presentation/multiplayer/RequestJoinSpaceViewModel.kt Added joinSpaceRequestJob and cancellation functionality, with conditional commands emission updates.
localization/src/main/res/values/strings.xml Added new strings for request sent notifications.
core-ui/src/main/java/com/anytypeio/anytype/core_ui/features/multiplayer/Joining.kt Introduced cancel callbacks in JoinSpaceScreen(s) and a new JoinSpaceRequestSentScreen with placeholders for button actions.
app/src/main/java/com/anytypeio/anytype/ui/multiplayer/RequestJoinSpaceFragment.kt Updated fragment to handle cancel actions triggered by the new cancel buttons.
Comments suppressed due to low confidence (1)

core-ui/src/main/java/com/anytypeio/anytype/core_ui/features/multiplayer/Joining.kt:224

  • The onClick handler for the 'done' button in JoinSpaceRequestSentScreen is empty. Ensure that an appropriate callback is provided if this functionality is expected.
onClick = throttledClick(onClick = {  })

@konstantiniiv konstantiniiv merged commit bd9ccaf into main May 23, 2025
3 checks passed
@konstantiniiv konstantiniiv deleted the droid-3659-support-link-without-approve branch May 23, 2025 14:05
@github-actions github-actions bot locked and limited conversation to collaborators May 23, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants