Skip to content

DROID-2966 Chat | Fix | Misc. UX fixes #2424

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
May 21, 2025
Merged

Conversation

uburoiubu
Copy link
Member

No description provided.

@uburoiubu uburoiubu requested a review from konstantiniiv as a code owner May 21, 2025 12:12
@uburoiubu uburoiubu requested a review from Copilot May 21, 2025 12:12
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR delivers miscellaneous UX improvements for chat interactions, including long-press menus, loading states for attachments, and resetting UI flags on send/edit.

  • Added long-click support and dropdown triggers on chat bubbles and attachments
  • Show loading placeholders and progress indicators for attachments in the chat box
  • Clear markup and attachments lists appropriately after sending or editing messages

Reviewed Changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated 4 comments.

Show a summary per file
File Description
ChatBubble.kt Hook up onAttachmentLongClicked to trigger dropdown
ChatBoxAttachments.kt Conditional title placeholder and upload spinner UI
ChatBox.kt Reset showMarkup flag after send
Attachments.kt Swapped to combinedClickable, cleaned imports
ChatViewModel.kt Attachment list build logic and clearing tweaks
ChatView.kt Extended Bookmark data class with loading flags
Comments suppressed due to low confidence (1)

feature-chats/src/main/java/com/anytypeio/anytype/feature_chats/presentation/ChatViewModel.kt:1064

  • [nitpick] The variable name curr is too terse. Consider renaming it to currentAttachments or similar to improve readability.
val curr = chatBoxAttachments.value

@uburoiubu uburoiubu merged commit 6ae2d9a into main May 21, 2025
3 checks passed
@uburoiubu uburoiubu deleted the DROID-2966-misc-fixes branch May 21, 2025 12:17
@github-actions github-actions bot locked and limited conversation to collaborators May 21, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants