DROID-3629 Onboarding | Flow update #2397
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
konstantiniiv
changed the title
uburoiubu
reviewed
May 13, 2025
| @@ -873,7 +915,7 @@ class OnboardingFragment : Fragment() { | |||
| private const val ONBOARDING_SPACE_PARAM = "space" | |||
| private const val ONBOARDING_STARTING_OBJECT_PARAM = "startingObject" | |||
|
|
|||
| private const val ONBOARDING_NAME_PARAM = "name" | |||
| private const val ONBOARDING_NAME_PARAM = "startingObject" | |||
There was a problem hiding this comment.
should be name or starting object? the relation between the value and constant name is confusing.
uburoiubu
reviewed
May 13, 2025
| @@ -77,7 +87,7 @@ fun AuthScreen( | |||
| Column(modifier = Modifier.fillMaxSize(), verticalArrangement = Arrangement.Center) { | |||
| Title(modifier = Modifier.align(Alignment.CenterHorizontally)) | |||
| Subtitle(modifier = Modifier) | |||
| Description() | |||
| //Description() | |||
There was a problem hiding this comment.
no longer valid? if yes, let's delete it.
uburoiubu
approved these changes
May 13, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
What type of PR is this? (check all applicable)
Related Tickets & Documents
Mobile & Desktop Screenshots/Recordings
Added tests?
Added to documentation?
[optional] Are there any post-deployment tasks we need to perform?