Skip to content

chore: 修复图表示例基础图表打不开的问题#7282

Merged
interstellarmt merged 1 commit intov5from
chore-fix-example
Mar 24, 2026
Merged

chore: 修复图表示例基础图表打不开的问题#7282
interstellarmt merged 1 commit intov5from
chore-fix-example

Conversation

@interstellarmt
Copy link
Copy Markdown
Member

Checklist
  • documents are updated
Description of change
  • 修复图表示例基础图表打不开的问题

Copilot AI review requested due to automatic review settings March 24, 2026 03:41
@gemini-code-assist
Copy link
Copy Markdown
Contributor

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

此拉取请求旨在解决图表示例中基础图表无法打开的问题。通过对示例文件 column-data-format.ts 进行路径重构,并引入相应的 meta.json 元数据文件以及中英文索引文件,确保了示例能够正确加载和显示。这些改动优化了示例的组织结构,并提升了文档站点的可用性。

Highlights

  • 修复图表示例问题: 解决了基础图表示例无法正常打开的问题,提升了用户体验。
  • 文件路径重构: 将 column-data-format.ts 示例文件移动到更合适的 analysis/process/demo 目录下。
  • 新增元数据和索引: 为重构后的示例路径添加了 meta.json 文件,并为“数据处理”类别新增了中英文索引文件。
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

此拉取请求通过重命名示例文件并添加必要的元数据和文档文件,成功修复了图表示例无法打开的问题。这些更改有助于将示例正确集成到网站结构中,提高了可访问性。

Comment on lines +2 to +5
"title": {
"zh": "中文分类",
"en": "Category"
},
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

当前 meta.json 文件中的 title 字段(“中文分类” / “Category”)对于此演示组来说过于通用。考虑到 process 部分的标题是“数据处理”,建议将此处的标题更改为更具描述性的内容,例如“数据格式示例”或“列数据格式示例”,以提高清晰度。

Suggested change
"title": {
"zh": "中文分类",
"en": "Category"
},
"title": {
"zh": "数据格式示例",
"en": "Data Format Examples"
},

Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds the missing documentation/index entry and a demo definition under site/examples/analysis/process, intended to fix the “基础图表打不开” issue by making the “数据处理 / Data Process” example section discoverable and renderable in the docs site.

Changes:

  • Add index.zh.md / index.en.md front-matter for the new analysis/process examples section.
  • Add demo/meta.json to register demos for the section.
  • Add a new demo (column-data-format.ts) showcasing column-major data input.

Reviewed changes

Copilot reviewed 3 out of 4 changed files in this pull request and generated 1 comment.

File Description
site/examples/analysis/process/index.zh.md Adds the Chinese doc section front-matter for the examples index.
site/examples/analysis/process/index.en.md Adds the English doc section front-matter for the examples index.
site/examples/analysis/process/demo/meta.json Registers the demo(s) for the new examples section.
site/examples/analysis/process/demo/column-data-format.ts Adds a new demo that uses column-major data with G2.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment on lines +4 to +5
---

No newline at end of file
Copy link

Copilot AI Mar 24, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Line 5 contains trailing whitespace (spaces on an otherwise empty line). Please remove it to keep Markdown front-matter files consistent with the rest of the examples and avoid whitespace-only diffs.

Suggested change
---
---

Copilot uses AI. Check for mistakes.
@interstellarmt interstellarmt merged commit 4730d52 into v5 Mar 24, 2026
8 of 9 checks passed
@interstellarmt interstellarmt deleted the chore-fix-example branch March 24, 2026 03:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants