[FlowAggregator] Improve logging and minor refactor in cert provider #7648
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Improve logging by using klog.InfoS consistently, adding extra log messages and improving correctness of some existing log messages. For example, "Updated client certificate" was sometimes displayed even in the absence of actual update. Rename some functions for clarity. Use "sync" and "update" as appropriate instead of "rotate" everywhere. Replace custom `pemToCertKey` with standard `tls.X509KeyPair` via new `parseKeyPair` helper for safer certificate/key pair parsing. Specify appropriate key usage (`ExtKeyUsageServerAuth` or `ExtKeyUsageClientAuth`) when verifying certificates instead of using `ExtKeyUsageAny`. Remove duplicate parsing of CA certificate/key PEM data by parsing once in `syncCertificates` and passing to `syncClientCertificate`. Make `GenerateCACertKey` and `GenerateCertKey` private. Note that the logic is overall unchanged, these changes are mostly cosmetic. Signed-off-by: Antonin Bas <[email protected]>
Contributor
Author
|
Sample logs with verbosity 3: |
antoninbas
added
the
area/flow-visibility/aggregator
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improve logging by using klog.InfoS consistently, adding extra log messages and improving correctness of some existing log messages. For example, "Updated client certificate" was sometimes displayed even in the absence of actual update.
Rename some functions for clarity. Use "sync" and "update" as appropriate instead of "rotate" everywhere.
Replace custom
pemToCertKeywith standardtls.X509KeyPairvia newparseKeyPairhelper for safer certificate/key pair parsing.Specify appropriate key usage (
ExtKeyUsageServerAuthorExtKeyUsageClientAuth) when verifying certificates instead of usingExtKeyUsageAny.Remove duplicate parsing of CA certificate/key PEM data by parsing once in
syncCertificatesand passing tosyncClientCertificate.Make
GenerateCACertKeyandGenerateCertKeyprivate.Note that the logic is overall unchanged, these changes are mostly cosmetic.