Skip to content

Conversation

@hongliangl
Copy link
Contributor

No description provided.

@hongliangl hongliangl force-pushed the 20251203-healthz-server-iptables branch from 393931f to 464f71c Compare December 4, 2025 02:03
@luolanzone luolanzone added this to the Antrea v2.6 release milestone Dec 19, 2025
@hongliangl hongliangl force-pushed the 20251203-healthz-server-iptables branch 3 times, most recently from 606d6be to b781414 Compare December 19, 2025 06:40
@hongliangl hongliangl force-pushed the 20251203-healthz-server-iptables branch from b781414 to e1e996a Compare December 22, 2025 09:32
Copy link
Contributor

@luolanzone luolanzone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM overall, one nit.

@hongliangl hongliangl force-pushed the 20251203-healthz-server-iptables branch from e1e996a to 4d7b407 Compare December 24, 2025 07:08
@hongliangl
Copy link
Contributor Author

/test-all

if c.nodeLatencyMonitorEnabled {
c.initNodeLatencyRules()
}
if c.proxyAll && c.proxyHealthCheckPort != 0 {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I noticed that !serviceHealthServerDisabled was also checked in #7371, it seems we also need to check it as well before install the rules?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't need to check that, in cmd/antrea-agent.go:

	var proxyHealthCheckPort int
	if !o.config.AntreaProxy.DisableServiceHealthCheckServer {
		_, proxyHealthCheckPortStr, _ := net.SplitHostPort(o.config.AntreaProxy.ServiceHealthCheckServerBindAddress)
		proxyHealthCheckPort, _ = strconv.Atoi(proxyHealthCheckPortStr)
	}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants