-
Notifications
You must be signed in to change notification settings - Fork 433
Install iptables rules to allow AntreaProxy health check packets #7605
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Install iptables rules to allow AntreaProxy health check packets #7605
Conversation
393931f to
464f71c
Compare
606d6be to
b781414
Compare
b781414 to
e1e996a
Compare
luolanzone
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM overall, one nit.
Signed-off-by: Hongliang Liu <[email protected]>
e1e996a to
4d7b407
Compare
|
/test-all |
| if c.nodeLatencyMonitorEnabled { | ||
| c.initNodeLatencyRules() | ||
| } | ||
| if c.proxyAll && c.proxyHealthCheckPort != 0 { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I noticed that !serviceHealthServerDisabled was also checked in #7371, it seems we also need to check it as well before install the rules?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We don't need to check that, in cmd/antrea-agent.go:
var proxyHealthCheckPort int
if !o.config.AntreaProxy.DisableServiceHealthCheckServer {
_, proxyHealthCheckPortStr, _ := net.SplitHostPort(o.config.AntreaProxy.ServiceHealthCheckServerBindAddress)
proxyHealthCheckPort, _ = strconv.Atoi(proxyHealthCheckPortStr)
}
No description provided.