feat: add ipsets to supportbundle #7552
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Anis KHALFALLAH <[email protected]>
luolanzone
reviewed
Dec 22, 2025
| return nil, fmt.Errorf("error saving ipset: %w, output: %s", err, string(output)) | ||
| } | ||
| return output, nil | ||
| } |
Contributor
There was a problem hiding this comment.
missing new line in the end.
| return writeFile(d.fs, filepath.Join(basedir, "iptables"), "iptables", data) | ||
| } | ||
|
|
||
| func (d *agentDumper) dumpIPSets(basedir string) error { |
Contributor
There was a problem hiding this comment.
Can you check and add unit tests for the new function?
hongliangl
reviewed
Dec 22, 2025
|
|
||
| ListEntries(name string) ([]string, error) | ||
|
|
||
| Save() ([]byte, error) |
Contributor
There was a problem hiding this comment.
You need to update the mock code in pkg/agent/util/ipset/testing/mock_ipset.go since you added the method Save().
| return writeFile(d.fs, filepath.Join(basedir, "iptables"), "iptables", data) | ||
| } | ||
|
|
||
| func (d *agentDumper) dumpIPSets(basedir string) error { |
Contributor
There was a problem hiding this comment.
Suggested change
| func (d *agentDumper) dumpIPSets(basedir string) error { | |
| func (d *agentDumper) dumpIPSet(basedir string) error { |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary :
Added ipsets information to supportbundle
Component:
pkg/support/dump_others.gopkg/agent/util/ipset/ipset.goCloses #7517