Skip to content

add an top resizer to modify the start of events #31

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Onatcer
Copy link

@Onatcer Onatcer commented Mar 13, 2025

Hi thank you for the amazing work with this library.

I'm currently looking into using it for solidtime. For that use case it would be beneficial to have a resizer on the top as well so i figured i'll make a PR for that.

The current state of the PR enables both the top and bottom resizer by default when {resize: true} is set.

addresses #47

@Onatcer
Copy link
Author

Onatcer commented May 19, 2025

@antoniandre I pulled the main branch in this again. there is one bug in this branch still and i struggle to understand why it happens, maybe you have a pointer for me:

When using the Top Resizer, it always triggers event-delayed-click in the end, which the bottom resizer does not. The events after dragging for the Bottom resizer are: cell-mouseup, event-resize-end, cell-click. For the Top one they are: event-mouseup, event-resize-end, event-click, event-delayed-click.

When i look at the events cell.vue the target element for the mouseup seems to be .vuecal__cell-events for the bottom resizer (

if ((e.target || e.e?.target).closest?.('.vuecal__event')) return
). So my guess is i have to make sure the .vuecal__cell-events overlays the resizer so it revieves the mouseup event.

The .vuecal__cell-events in Cell.vue relies on $slots['cell-events'] && cellEvents.length which appears to be false for me in both scenarios. So, yeah, I'm a bit out of ideas. If you could provide any pointers on where I would need to look to fix this behavior, it would be greatly appreciated.

@reitowo
Copy link

reitowo commented May 26, 2025

Nice work!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants