fix(ralph-wiggum): handle empty PROMPT_PARTS array with set -u#131
Open
stefanzvonar wants to merge 1 commit intoanthropics:mainfrom
Open
fix(ralph-wiggum): handle empty PROMPT_PARTS array with set -u#131stefanzvonar wants to merge 1 commit intoanthropics:mainfrom
stefanzvonar wants to merge 1 commit intoanthropics:mainfrom
Conversation
When invoking /ralph-loop without arguments, the script crashes with "PROMPT_PARTS[*]: unbound variable" instead of showing the helpful "No prompt provided" error message. The fix uses the :- operator to provide a default empty string when the array is empty, allowing the subsequent validation to handle it gracefully. Fixes anthropics#130
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
/ralph-loopwithout argumentsProblem
When running
/ralph-loopwith no prompt, the script crashes with:This happens because
set -euo pipefail(line 6) treats empty array expansion as unbound.Solution
Changed line 113 from:
PROMPT="${PROMPT_PARTS[*]}"To:
PROMPT="${PROMPT_PARTS[*]:-}"The
:-operator provides a default empty string, allowing the existing validation (lines 116-128) to handle the empty case and show the helpful usage message.Test plan
/ralph-loopwithout arguments - should show "No prompt provided" error with examples/ralph-loop Hello world- should work as beforeFixes #130