feat(bedrock): automatically infer AWS Region in Bedrock clients #918
+213
−173
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![stainless-app[bot]](https://avatars.githubusercontent.com/in/378072?s=60&v=4){kind=small}
src/anthropic/lib/bedrock/_client.py
Outdated
| try: | ||
| import boto3 | ||
|
|
||
| session = boto3.Session() |
There was a problem hiding this comment.
we also create a session in _auth.py so ideally we'd reuse it as they can be expensive
stainless-app
bot
changed the title
added 2 commits
April 1, 2025 14:51
|
tests seem to be failing which is pretty suspicious, changes here seem reasonable though. I suspect we're missing something but it is not clear to me what... |
|
moved to #974 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of only relying on the client param or
AWS_REGIONenv variable, we can also read this in from the existing AWS config (just like we do already for other Session tokens). This adds support for pulling in the region from the standard AWS config (using boto3).Resolves both of these issues: