-
Notifications
You must be signed in to change notification settings - Fork 75
feat: remove compatibility under React v18 #210
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
MadCcc
commented
Feb 5, 2025
- 移除对 React 18 以下版本的兼容
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
🎊 PR Preview 7a0eef6 has been successfully built and deployed to https://ant-design-cssinjs-preview-pr-210.surge.sh 🕐 Build time: 82.978s 🤖 By surge-preview |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## next #210 +/- ##
==========================================
- Coverage 94.88% 94.75% -0.13%
==========================================
Files 33 32 -1
Lines 2892 2823 -69
Branches 456 445 -11
==========================================
- Hits 2744 2675 -69
Misses 148 148 ☔ View full report in Codecov by Sentry. |
|
||
// DO NOT register functions in useEffect cleanup function, or functions that registered will never be called. | ||
const useCleanupRegister = (deps?: React.DependencyList) => { | ||
const useEffectCleanupRegister = (deps?: DependencyList) => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
纯血 css var 的话应该也不需要统计 cleanup 了?