Fixing issue on changing "disk_mode" #2096

[alezzandro]

Fixes #2096

SUMMARY

Fixing issue on changing "disk_mode" #2096.
As reported in the issue trying to change the disk_mode on an existing vm disk. If the disk is "independent_persistent" and I want to change it to "persistent" no change will be made. Other combinations also won't work.

I edited the vmware_guest_disk.py for including the disk_mode change in the VM reconfiguration if the disk_mode parameter is changing from the existing one.

ISSUE TYPE

• Bugfix Pull Request

COMPONENT NAME

community.vmware.vmware_guest_disk

ADDITIONAL INFORMATION

Please note I've just made a small change that still requires you to pass to the module at least the following information:

- name: VMware Change Disk Mode
  hosts: localhost
  tasks:
  - name: Change disk mode for virtual machine using name
    community.vmware.vmware_guest_disk:
      hostname: "{{ vcenter_hostname }}"
      username: "{{ vcenter_username }}"
      password: "{{ vcenter_password }}"
      datacenter: "{{ vcenter_dc }}"
      name: "{{ vm_name }}"
      validate_certs: false
      disk:
        - controller_number: "{{ vm_disk_controller_number }}"
          unit_number: "{{ vm_disk_unit_number }}"
          disk_mode: "persistent" 
          size_kb: "{{ vm_disk_size_kb }}"
    delegate_to: localhost
    register: disk_facts

[softwarefactory-project-zuul]

Build failed.
https://ansible.softwarefactory-project.io/zuul/buildset/483bd4fbfdfc418690ef485734696cbf

❌ ansible-tox-linters FAILURE in 4m 40s
⚠️ build-ansible-collection CANCELED
⚠️ ansible-test-cloud-integration-vcenter7_only-stable218 CANCELED
⚠️ ansible-test-cloud-integration-vcenter7_2esxi-stable218 CANCELED
⚠️ ansible-test-cloud-integration-vcenter7_1esxi-stable218_1_of_2 CANCELED
⚠️ ansible-test-cloud-integration-vcenter7_1esxi-stable218_2_of_2 CANCELED
⚠️ ansible-galaxy-importer CANCELED

[softwarefactory-project-zuul]

Build failed.
https://ansible.softwarefactory-project.io/zuul/buildset/ea33ee6ae6b74a82843ca67588a96e1f

✔️ ansible-tox-linters SUCCESS in 4m 42s
✔️ build-ansible-collection SUCCESS in 7m 19s
❌ ansible-test-cloud-integration-vcenter7_only-stable218 RETRY_LIMIT in 3m 21s
⚠️ ansible-test-cloud-integration-vcenter7_2esxi-stable218 CANCELED
⚠️ ansible-test-cloud-integration-vcenter7_1esxi-stable218_1_of_2 CANCELED
⚠️ ansible-test-cloud-integration-vcenter7_1esxi-stable218_2_of_2 CANCELED
✔️ ansible-galaxy-importer SUCCESS in 3m 23s

[mariolenz]

I'm sorry, I didn't find much time to work on this collection during the last weeks. I hope I'm able to review this PR soon.

[alezzandro]

@mariolenz any news?

[mariolenz]

Could you please add a changelog fragment?

It would be great to have a test case for this. Maybe we can re-use a disk that's created here:

community.vmware/tests/integration/targets/vmware_guest_disk/tasks/main.yml

Line 68 in ac3ad91

- name: create new disk(s) with valid disk mode

Something like

- name: Change disk mode
  vmware_guest_disk:
    hostname: "{{ vcenter_hostname }}"
    username: "{{ vcenter_username }}"
    password: "{{ vcenter_password }}"
    datacenter: "{{ dc1 }}"
    validate_certs: false
    name: test_vm1
    disk:
      - datastore: "{{ rw_datastore }}"
        disk_mode: "persistent"
        scsi_controller: 0
        scsi_type: 'paravirtual'
        size_gb: 1
        state: present
        type: eagerzeroedthick
        unit_number: 2
  register: test_change_disk_mode

- debug:
    msg: "{{ test_change_disk_mode }}"

- name: assert that changes were made
  assert:
    that:
      - test_change_disk_mode is changed

after this test maybe? That would be line 111.