vmware_dvs_portgroup: Remove mac_learning

[mariolenz]

SUMMARY

Remove mac_learning from vmware_dvs_portgroup.

ISSUE TYPE

• Feature Idea

COMPONENT NAME

#2360

[ihumster]

@mariolenz Mario, but you can a little more details - why?

[mariolenz]

This is the top level parameter mac_learning. There is another one, network_policy.mac_learning, which I've introduced as an alternative. Of course, this one shouldn't be removed.

The problem is that network_policy can be set to be inherited from the switch. This also affects MAC learning since, technically, it's a part of the configuration. Even if in the API its not "network policy" but MacManagementPolicy.

Having network_policy.mac_learning and dropping the top level mac_learning should make this clearer to users: If network_policy / MacManagementPolicy is inherited from the switch, the MAC learning stuff is also.

You can see in the code that MAC learning is really a sibling of promiscuous and so on:

community.vmware/plugins/modules/vmware_dvs_portgroup.py

Lines 545 to 556 in db4390b

	if not self.networkPolicy['inherited']:
	config.defaultPortConfig.macManagementPolicy.allowPromiscuous = self.networkPolicy['promiscuous']
	config.defaultPortConfig.macManagementPolicy.forgedTransmits = self.networkPolicy['forged_transmits']
	config.defaultPortConfig.macManagementPolicy.macChanges = self.networkPolicy['mac_changes']
	macLearning = self.networkPolicy['mac_learning']
	if macLearning:
	macLearningPolicy = vim.dvs.VmwareDistributedVirtualSwitch.MacLearningPolicy()
	macLearningPolicy.allowUnicastFlooding = macLearning['allow_unicast_flooding']
	macLearningPolicy.enabled = macLearning['enabled']
	macLearningPolicy.limit = macLearning['limit']
	macLearningPolicy.limitPolicy = macLearning['limit_policy']
	config.defaultPortConfig.macManagementPolicy.macLearningPolicy = macLearningPolicy