postgresql_publication: add row filter support

[gspanos]

SUMMARY

Add row filter support to postgresql_publication module, via an extra yaml parameter named rowfilters
This feature is supported since PG Version 15 (search "WHERE" or "row filter"):

• https://www.postgresql.org/docs/15/sql-createpublication.html
• https://www.postgresql.org/docs/15/sql-alterpublication.html

Some design decisions:

1. the parameter allows the user to include or omit the WHERE clause. Internally, if the clause exists we remove it and then add it before constructing the SQL fragment. This simplifies, among other things, the row filter comparison described below.
2. When it comes to idempotency, and detecting whether the row filter has changed or not, I opted for removing any quoting and whitespace and then compare the strings. The reason for that lies in how PG handles quoting and case sensitivity in general. For example if one writes the row filter condition WHERE ("id" > 10 ), the double quote(") character won't be retained in the pg_publication_tables.rowfilter column. So, short of writing an PG SQL parser, this was the best I could think of.

I have included integration tests for both creation and updating of a publication, and also for testing the "idempotency" handling described above.

ISSUE TYPE

• Feature Pull Request

COMPONENT NAME

postgresql_publication

ADDITIONAL INFORMATION

This will allow a user to declare a row filter, in conjuction with either tables or columns parameters like so:

  - name: Create publication with specific columns and row filter
    postgresql_publication:
      name: test_pub_rowfilter
      columns:
        mytable1: ['id', 'name']
      rowfilters:
        mytable1: '("id" > 10)'

or in combination with tables parameter

  - name: Create publication with specific columns and row filter
    postgresql_publication:
      name: test_pub_rowfilter
      tables: ['mytable1', 'someothertable2']
      rowfilters:
        mytable1: 'WHERE (id > 10)'

[Andersson007]

@gspanos thanks for the PR!
Could you please:

• Add a changelog fragment, use minor_changes:
• Add test tasks with check_mode: true to the tests. Also check with pg_query that nothing has actually changed
• Fix the red tests. If you click details and go to AZP, you'll see what the problems are
• Also you declare the parameters as mutually exclusive, please declare it in module = AnsibleModule(, there's a similar case already there
• Also an important question is if you feel committed to fix related bugs if they appear?

[Andersson007]

@gspanos thanks!

Could other maintainers please take a look?

[hunleyd]

LGTM