fix: enforce iso datestyle#715
Merged
Andersson007 merged 6 commits intoansible-collections:mainfrom Jul 1, 2024
Merged
Conversation
jbisabel
requested review from
Andersson007,
hunleyd and
jchancojr
as code owners
hunleyd
approved these changes
Jun 27, 2024
Collaborator
|
LGTM. The CI failures are unrelated |
hunleyd
requested changes
Jun 27, 2024
Collaborator
hunleyd
left a comment
hunleyd
left a comment
There was a problem hiding this comment.
please add a changelog fragment
Contributor
Author
|
Changelog fragment added |
hunleyd
approved these changes
Jun 28, 2024
Co-authored-by: Andrew Klychkov <aaklychkov@mail.ru>
Andersson007
approved these changes
Jun 28, 2024
Collaborator
|
as they are green, merging myself, thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SUMMARY
Fixes #711 by enforcing iso datestyle on the connection. This is only an issue when using psycopg3 in combination with datestyles that it doesn't support. Going by the docs, psycopg2 already does this when encountering a datestyle it doesn't recognize
ISSUE TYPE
COMPONENT NAME
postgres.py