Deprecate postgresql_lang#559
Conversation
elpavel
requested review from
Andersson007,
hunleyd and
jchancojr
as code owners
Andersson007
left a comment
Andersson007
left a comment
There was a problem hiding this comment.
@elpavel thanks for starting the process!
I think we should follow the official deprecation guide, could you please take a look?
Apologies for not mentioning this before
Andersson007
left a comment
Andersson007
left a comment
There was a problem hiding this comment.
LGTM
one more small formatting things
Co-authored-by: Andrew Klychkov <aaklychkov@mail.ru>
plugins/modules/postgresql_lang.py
Outdated
| module.warn("The postgresql_lang module has been deprecated and will be removed in community.postgresql 4.0.0") | ||
|
|
There was a problem hiding this comment.
| module.warn("The postgresql_lang module has been deprecated and will be removed in community.postgresql 4.0.0") |
i think we can remove it from here
|
@elpavel hm, it's strange, i see deprecations made same way in c.general, for example.. i'll ask the community |
|
@elpavel just remove the hyphens, i didn't notice them.. thanks @felixfontein ! |
Backport to stable-2: 💚 backport PR created✅ Backport PR branch: Backported as #562 🤖 @patchback |
Backport to stable-1: 💚 backport PR created✅ Backport PR branch: Backported as #563 🤖 @patchback |
* lang deprecated * lang deprecated * lang deprecated * postgresql_lang Co-authored-by: Andrew Klychkov <aaklychkov@mail.ru> * lang deprecated --------- Co-authored-by: Andrew Klychkov <aaklychkov@mail.ru> (cherry picked from commit 5655558)
* lang deprecated * lang deprecated * lang deprecated * postgresql_lang Co-authored-by: Andrew Klychkov <aaklychkov@mail.ru> * lang deprecated --------- Co-authored-by: Andrew Klychkov <aaklychkov@mail.ru> (cherry picked from commit 5655558)
* lang deprecated * lang deprecated * lang deprecated * postgresql_lang Co-authored-by: Andrew Klychkov <aaklychkov@mail.ru> * lang deprecated --------- Co-authored-by: Andrew Klychkov <aaklychkov@mail.ru> (cherry picked from commit 5655558) Co-authored-by: Pavel Rabel <128324708+elpavel@users.noreply.github.com>
* lang deprecated * lang deprecated * lang deprecated * postgresql_lang Co-authored-by: Andrew Klychkov <aaklychkov@mail.ru> * lang deprecated --------- Co-authored-by: Andrew Klychkov <aaklychkov@mail.ru> (cherry picked from commit 5655558) Co-authored-by: Pavel Rabel <128324708+elpavel@users.noreply.github.com>
4 participants
SUMMARY
Deprecating the postgresql_lang module.
The lang module works only on old Postgresql versions.
The documentation says
As of PostgreSQL 9.1, most procedural languages have been made into “extensions”, and should therefore be installed with CREATE EXTENSION not CREATE LANGUAGE.
ISSUE TYPE
COMPONENT NAME
postgresql_lang
ADDITIONAL INFORMATION
Fixes #519