"database" attribute of "postgresql_schema" being ignored?

[amossc]

SUMMARY

The database attribute is being ignored by postresql.postgresql_schema

ISSUE TYPE

• Bug Report

COMPONENT NAME

community.postgresql.postgresql_schema

ANSIBLE VERSION

2.10.17

COLLECTION VERSION

1.6.0

CONFIGURATION

OS / ENVIRONMENT

Ubuntu 20.04.3

STEPS TO REPRODUCE

- name: Create monitoring schema
  community.postgresql.postgresql_schema:
    name: "monitoring"
    owner: "monitoringuser"
    database: "monitoring"
    login_host: '{{ login_host }}'
    login_user: '{{ db_conn_user }}'
    login_password: '{{ db_conn_pass }}'

EXPECTED RESULTS

Schema monitoring created under the database monitoring

ACTUAL RESULTS

Schema monitoring is created under database postgres

[localhost] => {
     "changed": false,
     "invocation": {
         "module_args": {
             "ca_cert": null,
             "cascade_drop": false,
             "database": "postgres",
             "login_host": "host.name"
             "login_password": "VALUE_SPECIFIED_IN_NO_LOG_PARAMETER",
             "login_unix_socket": "",
             "login_user": "postgres",
             "name": "monitoring",
             "owner": "postgres",
             "port": 5432,
             "schema": "monitoring",
             "session_role": null,
             "ssl_mode": "prefer",
             "state": "present",
             "trust_input": true
         }
     },
     "queries": [],
     "schema": "monitoring"
}

[Andersson007]

@amossc hi, thanks for reporting this!
I've just checked an output from the following task from the integration tests after running it on Ubuntu 20.04:

56 # Test: CREATE SCHEMA
 57 - name: Create a new schema with name "acme"
 58   become_user: "{{ pg_user }}"
 59   become: yes
 60   postgresql_schema:
 61     database: "{{ db_name }}"
 62     name: acme
 63     login_user: "{{ pg_user }}"
 64     trust_input: yes
 65   register: result
 66 
 67 # Checks
 68 - assert:
 69     that:
 70       - result is changed
 71       - result.schema == 'acme'
 72       - result.queries == [ 'CREATE SCHEMA "acme"' ]

where db_name is ansible_db and it returned (as expected):

changed: [testhost] => {
    "changed": true,
    "invocation": {
        "module_args": {
            "ca_cert": null,
            "cascade_drop": false,
            "database": "ansible_db",
            "login_host": "",
            "login_password": "",
            "login_unix_socket": "",
            "login_user": "postgres",
            "name": "acme",
            "owner": "",
            "port": 5432,
            "schema": "acme",
            "session_role": null,
            "ssl_mode": "prefer",
            "state": "present",
            "trust_input": true
        }
    },
    "queries": [
        "CREATE SCHEMA \"acme\""
    ],
    "schema": "acme"
}

Maybe it's something related to the driver. Which version of the driver do you use?

[Andersson007]

In addition to the question above, do you get any warnings when running the task?

[Andersson007]

Created a PR #196.
@amossc do you have an opportunity to test the PR? It would be really great.
There are two ways:

1. https://github.com/ansible/community-docs/blob/main/test_pr_locally_guide.rst
2. or find the same file in your test vm with ansible where the problem exists, change the code the same way, check if the problem disappeared

What do you think?

[amossc]

Thanks for the quick response.
It appears that the problem was that that I was using an old version of the module (1.2.0).
Bumping it to 1.6.0 seems to have solved the problem without having to change the code.

I'll try to test the PR nevertheless, since you put the effort to open it.

[Andersson007]

@amossc thank you for the feedback!
Anyway your issue has helped to spot the deprecation.
The PR should prevent unexpected failures in the future when the database keyword connection argument support will be removed from psycopg2 (this already doesn't work in psycopg3 as i found out yesterday; it's also a good reminder about implementing psycopg3 support).
So I'll be waiting for you feedback on the PR, though no rush, thanks!

[codrinh]

I have the same issue using the following setup, tested your changes and the schemas are created

ansible [core 2.11.6] config file = None configured module search path = ['/home/user/.ansible/plugins/modules', '/usr/share/ansible/plugins/modules'] ansible python module location = /home/user/.local/lib/python3.9/site-packages/ansible ansible collection location = /home/user/.ansible/collections:/usr/share/ansible/collections executable location = /home/user/.local/bin/ansible python version = 3.9.7 (default, Sep 10 2021, 14:59:43) [GCC 11.2.0] jinja version = 3.0.3 libyaml = True

community.postgresql 1.1.1

python3-psycopg2.x86_64 - 2.8.6-1.rhel7

[Andersson007]

@codrinh hi, thank you for the feedback!

tested your changes and the schemas are created

Do you mean in the correct database passed through the database: argument or in postgres?

[codrinh]

I cannot reproduce the test as I added / removed lots of ansible parameters and I cannot remember the tested version. please disregard my previous comment

[Andersson007]

@codrinh thanks for the feedback!

[Andersson007]

thank you folks!