Skip to content

postgresql_privs: fix the module mistakes a procedure for a function#996

Merged
Andersson007 merged 3 commits intoansible-collections:mainfrom
Andersson007:postgresql_privs_func_bug
Sep 29, 2020
Merged

postgresql_privs: fix the module mistakes a procedure for a function#996
Andersson007 merged 3 commits intoansible-collections:mainfrom
Andersson007:postgresql_privs_func_bug

Conversation

@Andersson007
Copy link
Contributor

@Andersson007 Andersson007 commented Sep 29, 2020

SUMMARY

Fixes #994
postgresql_privs: fix the module mistakes a procedure for a function

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

plugins/modules/database/postgresql/postgresql_privs.py

@ansibullbot
Copy link
Collaborator

ansibullbot commented Sep 29, 2020

cc @Dorn- @andytom @b6d @jbscalia @kostiantyn-nemchenko @matburt @nerzhul @sebasmannem @tcraxs
click here for bot help

@ansibullbot ansibullbot added WIP Work in progress affects_2.10 bug This issue/PR relates to a bug database integration tests/integration module module needs_triage plugins plugin (any type) postgresql tests tests labels Sep 29, 2020
@Andersson007 Andersson007 changed the title [WIP] postgresql_privs: fix the module mistakes a procedure for a function postgresql_privs: fix the module mistakes a procedure for a function Sep 29, 2020
@ansibullbot ansibullbot added community_review and removed WIP Work in progress labels Sep 29, 2020
@Andersson007
Copy link
Contributor Author

Andersson007 commented Sep 29, 2020

cc @ilicmilan

@Andersson007
Copy link
Contributor Author

Andersson007 commented Sep 29, 2020

ready_for_review

@Andersson007 Andersson007 mentioned this pull request Sep 29, 2020
Closed
@ilicmilan
Copy link
Contributor

ilicmilan commented Sep 29, 2020

LGTM

@Andersson007 Andersson007 mentioned this pull request Sep 29, 2020
Closed
martinm82
martinm82 reviewed Sep 29, 2020
View reviewed changes
martinm82
martinm82 reviewed Sep 29, 2020
View reviewed changes
Copy link
Contributor

@martinm82 martinm82 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

BTW, really nice that you added the test. Makes it easier to review the changes even if have not the full picture.

@Andersson007 Andersson007 merged commit 2200517 into ansible-collections:main Sep 29, 2020
@Andersson007
Copy link
Contributor Author

Andersson007 commented Sep 29, 2020

@ilicmilan @martinm82 thanks for reviewing and approving!

patchback bot pushed a commit that referenced this pull request Sep 29, 2020
@Andersson007
postgresql_privs: fix the module mistakes a procedure for a function (#…
95bebf2 
…996)

* postgresql_privs: fix the module mistakes a procedure for a function

* add changelog fragment

* fix

(cherry picked from commit 2200517)
@patchback patchback bot mentioned this pull request Sep 29, 2020
Merged
@Andersson007
Copy link
Contributor Author

Andersson007 commented Sep 29, 2020

@martinm82 @ilicmilan feel free to mention me in PRs whenever a review needed:)

Andersson007 added a commit that referenced this pull request Sep 29, 2020
@patchback @Andersson007
postgresql_privs: fix the module mistakes a procedure for a function (#…
db24f98 
…996) (#1006)

* postgresql_privs: fix the module mistakes a procedure for a function

* add changelog fragment

* fix

(cherry picked from commit 2200517)

Co-authored-by: Andrew Klychkov <aaklychkov@mail.ru>
@Andersson007 Andersson007 mentioned this pull request Sep 30, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@martinm82 martinm82 martinm82 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

bug This issue/PR relates to a bug community_review database has_issue integration tests/integration module module plugins plugin (any type) postgresql tests tests

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

postgresql_privs module mistakes a procedure for a function

4 participants

@Andersson007 @ansibullbot @ilicmilan @martinm82