Skip to content

Add NominalPower#1644

Open
upcu wants to merge 2 commits intoangularsen:masterfrom
upcu:add-nominal-power
Open

Add NominalPower#1644
upcu wants to merge 2 commits intoangularsen:masterfrom
upcu:add-nominal-power

Conversation

@upcu
Copy link

@upcu upcu commented Jan 14, 2026

@upcu upcu closed this Feb 16, 2026
@upcu upcu reopened this Feb 16, 2026
Copy link
Owner

@angularsen angularsen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution! A couple of things need to be fixed in NominalPower.json:

1. Missing BaseDimensions

NominalPower is dimensionally equivalent to Power (W = kg·m²/s³). The quantity definition needs BaseDimensions, same as Power.json:

"BaseDimensions": {
  "L": 2,
  "M": 1,
  "T": -3
}

2. Missing BaseUnits on WattPeak

The WattPeak unit needs BaseUnits to map to SI base units, same as Power.json's Watt:

"BaseUnits": {
  "L": "Meter",
  "M": "Kilogram",
  "T": "Second"
}

Please add these and the PR should be good to go!

private void GenerateConversionMethods()
{
Writer.WL($@"
#region Conversion Methods
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please don't change generator code unless intentional

@@ -0,0 +1,25 @@
{
"Name": "NominalPower",
Copy link
Owner

@angularsen angularsen Feb 27, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we rename this to disambiguate this from other kinds of nominal power?
It seems maybe a bit ambiguous: https://en.wikipedia.org/wiki/Nominal_power

For example, NominalPowerPhotovoltaic

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants