Skip to content
This repository was archived by the owner on Jul 29, 2024. It is now read-only.

Upgrade to jasmine 3.1.0 #4809

Closed
wants to merge 3 commits into from
Closed

Conversation

awarecan
Copy link

resolve #4788, #4708

Jamine 3 change the random default to true, however I want to keep protractor's default to false to avoid breaking changes.
done() accept error as parameter in Jasmine 3
beforeEach() no longer allow in it() in Jasmine 3

@awarecan
Copy link
Author

awarecan commented May 10, 2018

@qiyigg Could you help to review it again? I messed up previous PR.

To answer two of your code review concern in previous PR:

  1. why remove this?
    expect(e.code).toBe(BrowserError.CODE);

The purpose of this test is validate if error be thrown, not to verify the error code. I am not sure what is the root cause, but the exception don't have code property on my environment, the test will fail.

  1. }, done());
    The "then" function receives a Function as parameter, passing done() to it will call "done" first and make the test always pass, won't it?

This test is expecting exception thrown, so if error occurred, done(), test passed.
One big change in Jasmine 3 is done() accept one parameter now, if we pass done function here, done(e) will be called, Jasmine will fail the test.
I sightly changed the code in this PR to }, function() { return done(); });

awarecan and others added 2 commits May 10, 2018 17:18
angular#4837)

This patch fixes the continually breaking circleci build. The changes made were:
- Switch to using circleci v2 syntax, as the v1 syntax will be deprecated in August.
  It also permits running this build locally using the `circleci` commandline tool.
- Adjust timeouts on error tests to fail consistently on high-performance machines.
- Correct error formatting on error tests.
@googlebot
Copy link

So there's good news and bad news.

👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there.

😕 The bad news is that it appears that one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request.

Note to project maintainer: This is a terminal state, meaning the cla/google commit status will not change from this state. It's up to you to confirm consent of the commit author(s) and merge this pull request when appropriate.

1 similar comment
@googlebot
Copy link

So there's good news and bad news.

👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there.

😕 The bad news is that it appears that one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request.

Note to project maintainer: This is a terminal state, meaning the cla/google commit status will not change from this state. It's up to you to confirm consent of the commit author(s) and merge this pull request when appropriate.

@googlebot googlebot added cla: no and removed cla: yes labels Jun 4, 2018
@awarecan
Copy link
Author

awarecan commented Jun 4, 2018

Did I just ruined my PR again?

@qiyigg
Copy link
Contributor

qiyigg commented Jun 4, 2018

@awarecan I guess so... what you need to do is:
fetch the latest master branch
rebase your pr on that branch

@awarecan
Copy link
Author

awarecan commented Jun 4, 2018

Recreate a new PR

@awarecan awarecan closed this Jun 4, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Upgrade to jasmine 3.1.0
4 participants