-
Notifications
You must be signed in to change notification settings - Fork 2.3k
Conversation
@qiyigg Could you help to review it again? I messed up previous PR. To answer two of your code review concern in previous PR:
The purpose of this test is validate if error be thrown, not to verify the error code. I am not sure what is the root cause, but the exception don't have code property on my environment, the test will fail.
This test is expecting exception thrown, so if error occurred, done(), test passed. |
angular#4837) This patch fixes the continually breaking circleci build. The changes made were: - Switch to using circleci v2 syntax, as the v1 syntax will be deprecated in August. It also permits running this build locally using the `circleci` commandline tool. - Adjust timeouts on error tests to fail consistently on high-performance machines. - Correct error formatting on error tests.
So there's good news and bad news. 👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there. 😕 The bad news is that it appears that one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request. Note to project maintainer: This is a terminal state, meaning the |
1 similar comment
So there's good news and bad news. 👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there. 😕 The bad news is that it appears that one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request. Note to project maintainer: This is a terminal state, meaning the |
Did I just ruined my PR again? |
@awarecan I guess so... what you need to do is: |
Recreate a new PR |
resolve #4788, #4708
Jamine 3 change the random default to true, however I want to keep protractor's default to false to avoid breaking changes.
done() accept error as parameter in Jasmine 3
beforeEach() no longer allow in it() in Jasmine 3